From: Jakub Kicinski <kuba@kernel•org>
To: davem@davemloft•net
Cc: netdev@vger•kernel.org, jiri@resnulli•us, leon@kernel•org,
mkubecek@suse•cz, andrew@lunn•ch, f.fainelli@gmail•com,
Jakub Kicinski <kuba@kernel•org>
Subject: [PATCH net-next 0/4] improve ethtool/rtnl vs devlink locking
Date: Fri, 29 Oct 2021 21:06:07 -0700 [thread overview]
Message-ID: <20211030040611.1751638-1-kuba@kernel.org> (raw)
During ethtool netlink development we decided to move some of
the commmands to devlink. Since we don't want drivers to implement
both devlink and ethtool version of the commands ethtool ioctl
falls back to calling devlink. Unfortunately devlink locks must
be taken before rtnl_lock. This results in a questionable
dev_hold() / rtnl_unlock() / devlink / rtnl_lock() / dev_put()
pattern.
This method "works" but it working depends on drivers in question
not doing much in ethtool_ops->begin / complete, and on the netdev
not having needs_free_netdev set.
Since commit 437ebfd90a25 ("devlink: Count struct devlink consumers")
we can hold a reference on a devlink instance and prevent it from
going away (sort of like netdev with dev_hold()). We can use this
to create a more natural reference nesting where we get a ref on
the devlink instance and make the devlink call entirely outside
of the rtnl_lock section.
Jakub Kicinski (4):
ethtool: push the rtnl_lock into dev_ethtool()
ethtool: handle info/flash data copying outside rtnl_lock
devlink: expose get/put functions
ethtool: don't drop the rtnl_lock half way thru the ioctl
include/net/devlink.h | 16 ++++-
net/core/dev_ioctl.c | 2 -
net/core/devlink.c | 53 ++++-----------
net/ethtool/ioctl.c | 148 ++++++++++++++++++++++++++++++------------
4 files changed, 134 insertions(+), 85 deletions(-)
--
2.31.1
next reply other threads:[~2021-10-30 4:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-30 4:06 Jakub Kicinski [this message]
2021-10-30 4:06 ` [PATCH net-next 1/4] ethtool: push the rtnl_lock into dev_ethtool() Jakub Kicinski
2021-10-30 4:06 ` [PATCH net-next 2/4] ethtool: handle info/flash data copying outside rtnl_lock Jakub Kicinski
2021-10-30 4:06 ` [PATCH net-next 3/4] devlink: expose get/put functions Jakub Kicinski
2021-10-30 4:06 ` [PATCH net-next 4/4] ethtool: don't drop the rtnl_lock half way thru the ioctl Jakub Kicinski
2021-10-30 8:50 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211030040611.1751638-1-kuba@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=leon@kernel$(echo .)org \
--cc=mkubecek@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox