Subject: Re: [PATCH 1/3] fec_phy: add new PHY file

From: kernel test robot <[email-masked]>
Date: Fri, 12 Nov 2021 05:46:25 +0800

Hi Apeksha,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]
[also build test ERROR on net/master soc/for-next linus/master v5.15 next-20211111]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Apeksha-Gupta/drivers-net-split-FEC-driver/20211110-133837
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 84882cf72cd774cf16fd338bdbf00f69ac9f9194
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/29dd4ea8a884ac6d592406e768c919f7b3db1417
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Apeksha-Gupta/drivers-net-split-FEC-driver/20211110-133837
        git checkout 29dd4ea8a884ac6d592406e768c919f7b3db1417
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email-masked]>

All errors (new ones prefixed by >>):

   drivers/net/ethernet/freescale/fec_phy.c: In function 'fec_enet_adjust_link':
>> drivers/net/ethernet/freescale/fec_phy.c:58:25: error: implicit declaration of function 'fec_restart'; did you mean 'dev_restart'? [-Werror=implicit-function-declaration]
      58 |                         fec_restart(ndev);
         |                         ^~~~~~~~~~~
         |                         dev_restart
>> drivers/net/ethernet/freescale/fec_phy.c:67:25: error: implicit declaration of function 'fec_stop' [-Werror=implicit-function-declaration]
      67 |                         fec_stop(ndev);
         |                         ^~~~~~~~
   cc1: some warnings being treated as errors

vim +58 drivers/net/ethernet/freescale/fec_phy.c

    25	
    26	void fec_enet_adjust_link(struct net_device *ndev)
    27	{
    28		struct fec_enet_private *fep = netdev_priv(ndev);
    29		struct phy_device *phy_dev = ndev->phydev;
    30		int status_change = 0;
    31	
    32		/* If the netdev is down, or is going down, we're not interested
    33		 * in link state events, so just mark our idea of the link as down
    34		 * and ignore the event.
    35		 */
    36		if (!netif_running(ndev) || !netif_device_present(ndev)) {
    37			fep->link = 0;
    38		} else if (phy_dev->link) {
    39			if (!fep->link) {
    40				fep->link = phy_dev->link;
    41				status_change = 1;
    42			}
    43	
    44			if (fep->full_duplex != phy_dev->duplex) {
    45				fep->full_duplex = phy_dev->duplex;
    46				status_change = 1;
    47			}
    48	
    49			if (phy_dev->speed != fep->speed) {
    50				fep->speed = phy_dev->speed;
    51				status_change = 1;
    52			}
    53	
    54			/* if any of the above changed restart the FEC */
    55			if (status_change) {
    56				napi_disable(&fep->napi);
    57				netif_tx_lock_bh(ndev);
  > 58				fec_restart(ndev);
    59				netif_tx_wake_all_queues(ndev);
    60				netif_tx_unlock_bh(ndev);
    61				napi_enable(&fep->napi);
    62			}
    63		} else {
    64			if (fep->link) {
    65				napi_disable(&fep->napi);
    66				netif_tx_lock_bh(ndev);
  > 67				fec_stop(ndev);
    68				netif_tx_unlock_bh(ndev);
    69				napi_enable(&fep->napi);
    70				fep->link = phy_dev->link;
    71				status_change = 1;
    72			}
    73		}
    74	
    75		if (status_change)
    76			phy_print_status(phy_dev);
    77	}
    78	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email-masked]