From: Christoph Hellwig <hch@lst•de>
To: Tianyu Lan <ltykernel@gmail•com>
Cc: dave.hansen@linux•intel.com, luto@kernel•org,
peterz@infradead•org, tglx@linutronix•de, mingo@redhat•com,
bp@alien8•de, x86@kernel•org, hpa@zytor•com, jgross@suse•com,
sstabellini@kernel•org, boris.ostrovsky@oracle•com,
kys@microsoft•com, haiyangz@microsoft•com,
sthemmin@microsoft•com, wei.liu@kernel•org, decui@microsoft•com,
joro@8bytes•org, will@kernel•org, davem@davemloft•net,
kuba@kernel•org, jejb@linux•ibm.com, martin.petersen@oracle•com,
hch@lst•de, m.szyprowski@samsung•com, robin.murphy@arm•com,
xen-devel@lists•xenproject.org, michael.h.kelley@microsoft•com,
Tianyu Lan <Tianyu.Lan@microsoft•com>,
iommu@lists•linux-foundation.org, linux-hyperv@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-scsi@vger•kernel.org,
netdev@vger•kernel.org, vkuznets@redhat•com,
brijesh.singh@amd•com, konrad.wilk@oracle•com,
parri.andrea@gmail•com, thomas.lendacky@amd•com,
dave.hansen@intel•com
Subject: Re: [PATCH 1/5] x86/Swiotlb: Add Swiotlb bounce buffer remap function for HV IVM
Date: Wed, 17 Nov 2021 10:59:53 +0100 [thread overview]
Message-ID: <20211117095953.GA10330@lst.de> (raw)
In-Reply-To: <20211116153923.196763-2-ltykernel@gmail.com>
The subject is wrong, nothing x86-specific here. Please use
"swiotlb: " as the prefix
> + * @vaddr: The vaddr of the swiotlb memory pool. The swiotlb
> + * memory pool may be remapped in the memory encrypted case and store
Please avoid the overly long line.
> + /*
> + * With swiotlb_unencrypted_base setting, swiotlb bounce buffer will
> + * be remapped in the swiotlb_update_mem_attributes() and return here
> + * directly.
> + */
I'd word this as:
/*
* If swiotlb_unencrypted_base is set, the bounce buffer memory will
* be remapped and cleared in swiotlb_update_mem_attributes.
*/
> + ret = swiotlb_init_io_tlb_mem(mem, __pa(tlb), nslabs, false);
> + if (ret) {
> + memblock_free(mem->slots, alloc_size);
> + return ret;
> + }
With the latest update swiotlb_init_io_tlb_mem will always return 0,
so no need for the return value change or error handling here.
next prev parent reply other threads:[~2021-11-17 10:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 15:39 [PATCH 0/5] x86/Hyper-V: Add Hyper-V Isolation VM support(Second part) Tianyu Lan
2021-11-16 15:39 ` [PATCH 1/5] x86/Swiotlb: Add Swiotlb bounce buffer remap function for HV IVM Tianyu Lan
2021-11-17 9:59 ` Christoph Hellwig [this message]
2021-11-17 13:32 ` Tianyu Lan
2021-11-16 15:39 ` [PATCH 2/5] dma-mapping: Add vmap/vunmap_noncontiguous() callback in dma ops Tianyu Lan
2021-11-16 15:39 ` [PATCH 3/5] hyperv/IOMMU: Enable swiotlb bounce buffer for Isolation VM Tianyu Lan
2021-11-16 19:12 ` Borislav Petkov
2021-11-17 13:22 ` Tianyu Lan
2021-11-17 10:01 ` Christoph Hellwig
2021-11-17 14:00 ` Tianyu Lan
2021-11-19 14:23 ` Tianyu Lan
2021-11-26 7:40 ` Christoph Hellwig
2021-11-26 11:39 ` Tianyu Lan
2021-11-16 15:39 ` [PATCH 4/5] net: netvsc: Add Isolation VM support for netvsc driver Tianyu Lan
2021-11-16 15:39 ` [PATCH 5/5] scsi: storvsc: Add Isolation VM support for storvsc driver Tianyu Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211117095953.GA10330@lst.de \
--to=hch@lst$(echo .)de \
--cc=Tianyu.Lan@microsoft$(echo .)com \
--cc=boris.ostrovsky@oracle$(echo .)com \
--cc=bp@alien8$(echo .)de \
--cc=brijesh.singh@amd$(echo .)com \
--cc=dave.hansen@intel$(echo .)com \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=decui@microsoft$(echo .)com \
--cc=haiyangz@microsoft$(echo .)com \
--cc=hpa@zytor$(echo .)com \
--cc=iommu@lists$(echo .)linux-foundation.org \
--cc=jejb@linux$(echo .)ibm.com \
--cc=jgross@suse$(echo .)com \
--cc=joro@8bytes$(echo .)org \
--cc=konrad.wilk@oracle$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kys@microsoft$(echo .)com \
--cc=linux-hyperv@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=ltykernel@gmail$(echo .)com \
--cc=luto@kernel$(echo .)org \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=martin.petersen@oracle$(echo .)com \
--cc=michael.h.kelley@microsoft$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=parri.andrea@gmail$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=robin.murphy@arm$(echo .)com \
--cc=sstabellini@kernel$(echo .)org \
--cc=sthemmin@microsoft$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=thomas.lendacky@amd$(echo .)com \
--cc=vkuznets@redhat$(echo .)com \
--cc=wei.liu@kernel$(echo .)org \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=xen-devel@lists$(echo .)xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox