Subject: Re: [PATCH 08/17] ath11k: Use memset_startat() for clearing queue descriptors

From: Kees Cook <[email-masked]>
Date: Tue, 14 Dec 2021 09:05:37 -0800

On Tue, Dec 14, 2021 at 05:46:31PM +0200, Kalle Valo wrote:
> Kalle Valo <[email-masked]> writes:
> 
> > Kees Cook <[email-masked]> writes:
> >
> >> In preparation for FORTIFY_SOURCE performing compile-time and run-time
> >> field bounds checking for memset(), avoid intentionally writing across
> >> neighboring fields.
> >>
> >> Use memset_startat() so memset() doesn't get confused about writing
> >> beyond the destination member that is intended to be the starting point
> >> of zeroing through the end of the struct. Additionally split up a later
> >> field-spanning memset() so that memset() can reason about the size.
> >>
> >> Cc: Kalle Valo <[email-masked]>
> >> Cc: "David S. Miller" <[email-masked]>
> >> Cc: Jakub Kicinski <[email-masked]>
> >> Cc: [email-masked]
> >> Cc: [email-masked]
> >> Cc: [email-masked]
> >> Signed-off-by: Kees Cook <[email-masked]>
> >
> > What's the plan for this patch? I would like to take this via my ath
> > tree to avoid conflicts.
> 
> Actually this has been already applied:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=ath-next&id=d5549e9a6b86
> 
> Why are you submitting the same patch twice?

These are all part of a topic branch, and the cover letter mentioned
that a set of them have already been taken but haven't appeared in -next
(which was delayed).

Sorry for the confusion!

-- 
Kees Cook