From: M Chetan Kumar <m.chetan.kumar@linux•intel.com>
To: netdev@vger•kernel.org
Cc: kuba@kernel•org, davem@davemloft•net, johannes@sipsolutions•net,
ryazanov.s.a@gmail•com, loic.poulain@linaro•org,
krishna.c.sudi@intel•com, m.chetan.kumar@intel•com,
m.chetan.kumar@linux•intel.com, linuxwwan@intel•com,
kai.heng.feng@canonical•com
Subject: [PATCH net-next] Revert "net: wwan: iosm: Keep device at D0 for s2idle case"
Date: Tue, 4 Jan 2022 20:32:13 +0530 [thread overview]
Message-ID: <20220104150213.1894-1-m.chetan.kumar@linux.intel.com> (raw)
Depending on BIOS configuration IOSM driver exchanges
protocol required for putting device into D3L2 or D3L1.2.
ipc_pcie_suspend_s2idle() is implemented to put device to D3L1.2.
This patch forces PCI core know this device should stay at D0.
- pci_save_state()is expensive since it does a lot of slow PCI
config reads.
The reported issue is not observed on x86 platform. The supurios
wake on AMD platform needs to be futher debugged with orignal patch
submitter [1]. Also the impact of adding pci_save_state() needs to be
assessed by testing it on other platforms.
This reverts commit f4dd5174e273("net: wwan: iosm: Keep device
at D0 for s2idle case").
[1] https://lore.kernel.org/all/20211224081914.345292-2-kai.heng.feng@canonical.com/
Signed-off-by: M Chetan Kumar <m.chetan.kumar@linux•intel.com>
---
drivers/net/wwan/iosm/iosm_ipc_pcie.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wwan/iosm/iosm_ipc_pcie.c b/drivers/net/wwan/iosm/iosm_ipc_pcie.c
index af1d0e837fe9..d73894e2a84e 100644
--- a/drivers/net/wwan/iosm/iosm_ipc_pcie.c
+++ b/drivers/net/wwan/iosm/iosm_ipc_pcie.c
@@ -340,9 +340,6 @@ static int __maybe_unused ipc_pcie_suspend_s2idle(struct iosm_pcie *ipc_pcie)
ipc_imem_pm_s2idle_sleep(ipc_pcie->imem, true);
- /* Let PCI core know this device should stay at D0 */
- pci_save_state(ipc_pcie->pci);
-
return 0;
}
--
2.25.1
next reply other threads:[~2022-01-04 14:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 15:02 M Chetan Kumar [this message]
2022-01-05 2:30 ` [PATCH net-next] Revert "net: wwan: iosm: Keep device at D0 for s2idle case" patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220104150213.1894-1-m.chetan.kumar@linux.intel.com \
--to=m.chetan.kumar@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=johannes@sipsolutions$(echo .)net \
--cc=kai.heng.feng@canonical$(echo .)com \
--cc=krishna.c.sudi@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linuxwwan@intel$(echo .)com \
--cc=loic.poulain@linaro$(echo .)org \
--cc=m.chetan.kumar@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ryazanov.s.a@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox