From: Vladimir Oltean <vladimir.oltean@nxp•com>
To: "netdev@vger•kernel.org" <netdev@vger•kernel.org>
Cc: "David S. Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>, Andrew Lunn <andrew@lunn•ch>,
Vivien Didelot <vivien.didelot@gmail•com>,
Florian Fainelli <f.fainelli@gmail•com>
Subject: Re: [PATCH v2 net-next 0/7] Cleanup to main DSA structures
Date: Wed, 5 Jan 2022 14:28:38 +0000 [thread overview]
Message-ID: <20220105142838.uzanzmozesap63om@skbuf> (raw)
In-Reply-To: <20220105132141.2648876-1-vladimir.oltean@nxp.com>
On Wed, Jan 05, 2022 at 03:21:34PM +0200, Vladimir Oltean wrote:
> This series contains changes that do the following:
>
> - struct dsa_port reduced from 576 to 544 bytes, and first cache line a
> bit better organized
> - struct dsa_switch from 160 to 136 bytes, and first cache line a bit
> better organized
> - struct dsa_switch_tree from 112 to 104 bytes, and first cache line a
> bit better organized
>
> No changes compared to v1, just split into a separate patch set.
>
> Vladimir Oltean (7):
> net: dsa: move dsa_port :: stp_state near dsa_port :: mac
> net: dsa: merge all bools of struct dsa_port into a single u8
> net: dsa: move dsa_port :: type near dsa_port :: index
> net: dsa: merge all bools of struct dsa_switch into a single u32
> net: dsa: make dsa_switch :: num_ports an unsigned int
> net: dsa: move dsa_switch_tree :: ports and lags to first cache line
> net: dsa: combine two holes in struct dsa_switch_tree
>
> include/net/dsa.h | 146 +++++++++++++++++++++++++---------------------
> net/dsa/dsa2.c | 2 +-
> 2 files changed, 81 insertions(+), 67 deletions(-)
>
> --
> 2.25.1
>
Let's keep this version for review only (RFC). For the final version I
just figured that I can use this syntax:
u8 vlan_filtering:1;
/* Managed by DSA on user ports and by drivers on CPU and DSA ports */
u8 learning:1;
u8 lag_tx_enabled:1;
u8 devlink_port_setup:1;
u8 setup:1;
instead of this syntax:
u8 vlan_filtering:1,
/* Managed by DSA on user ports and by
* drivers on CPU and DSA ports
*/
learning:1,
lag_tx_enabled:1,
devlink_port_setup:1,
setup:1;
which is what I'm going to prefer.
next prev parent reply other threads:[~2022-01-05 14:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 13:21 [PATCH v2 net-next 0/7] Cleanup to main DSA structures Vladimir Oltean
2022-01-05 13:21 ` [PATCH v2 net-next 1/7] net: dsa: move dsa_port :: stp_state near dsa_port :: mac Vladimir Oltean
2022-01-05 18:30 ` Florian Fainelli
2022-01-05 13:21 ` [PATCH v2 net-next 2/7] net: dsa: merge all bools of struct dsa_port into a single u8 Vladimir Oltean
2022-01-05 18:30 ` Florian Fainelli
2022-01-05 18:39 ` Vladimir Oltean
2022-01-05 18:46 ` Florian Fainelli
2022-01-05 18:56 ` Vladimir Oltean
2022-01-05 19:42 ` Florian Fainelli
2022-01-05 22:10 ` Andrew Lunn
2022-01-05 13:21 ` [PATCH v2 net-next 3/7] net: dsa: move dsa_port :: type near dsa_port :: index Vladimir Oltean
2022-01-05 18:31 ` Florian Fainelli
2022-01-05 13:21 ` [PATCH v2 net-next 4/7] net: dsa: merge all bools of struct dsa_switch into a single u32 Vladimir Oltean
2022-01-05 18:32 ` Florian Fainelli
2022-01-05 13:21 ` [PATCH v2 net-next 5/7] net: dsa: make dsa_switch :: num_ports an unsigned int Vladimir Oltean
2022-01-05 18:33 ` Florian Fainelli
2022-01-05 13:21 ` [PATCH v2 net-next 6/7] net: dsa: move dsa_switch_tree :: ports and lags to first cache line Vladimir Oltean
2022-01-05 18:34 ` Florian Fainelli
2022-01-05 13:21 ` [PATCH v2 net-next 7/7] net: dsa: combine two holes in struct dsa_switch_tree Vladimir Oltean
2022-01-05 18:34 ` Florian Fainelli
2022-01-05 14:28 ` Vladimir Oltean [this message]
2022-01-05 18:37 ` [PATCH v2 net-next 0/7] Cleanup to main DSA structures Florian Fainelli
2022-01-05 18:39 ` Florian Fainelli
2022-01-05 18:59 ` Vladimir Oltean
2022-01-05 19:04 ` Florian Fainelli
2022-01-05 19:22 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220105142838.uzanzmozesap63om@skbuf \
--to=vladimir.oltean@nxp$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vivien.didelot@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox