From: kernel test robot <lkp@intel•com>
To: Arthur Kiyanovski <akiyano@amazon•com>,
David Miller <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>
Cc: kbuild-all@lists•01.org, netdev@vger•kernel.org,
Arthur Kiyanovski <akiyano@amazon•com>,
"Woodhouse, David" <dwmw@amazon•com>,
"Machulsky, Zorik" <zorik@amazon•com>,
"Matushevsky, Alexander" <matua@amazon•com>,
Saeed Bshara <saeedb@amazon•com>, "Wilson, Matt" <msw@amazon•com>,
"Liguori, Anthony" <aliguori@amazon•com>
Subject: Re: [PATCH V1 net-next 10/10] net: ena: Extract recurring driver reset code into a function
Date: Sat, 8 Jan 2022 18:33:08 +0800 [thread overview]
Message-ID: <202201081810.cbanKMEo-lkp@intel.com> (raw)
In-Reply-To: <20220106192915.22616-11-akiyano@amazon.com>
Hi Arthur,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Arthur-Kiyanovski/ENA-capabilities-field-and-cosmetic/20220107-034036
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 710ad98c363a66a0cd8526465426c5c5f8377ee0
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20220108/202201081810.cbanKMEo-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/fc12048d64c67fe13a46a2a3932df606c29ac4d9
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Arthur-Kiyanovski/ENA-capabilities-field-and-cosmetic/20220107-034036
git checkout fc12048d64c67fe13a46a2a3932df606c29ac4d9
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash drivers/net/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel•com>
All warnings (new ones prefixed by >>):
In file included from drivers/net/ethernet/amazon/ena/ena_netdev.c:21:
drivers/net/ethernet/amazon/ena/ena_netdev.h: In function 'ena_reset_device':
>> drivers/net/ethernet/amazon/ena/ena_netdev.h:399:31: warning: implicit conversion from 'enum ena_flags_t' to 'enum ena_regs_reset_reason_types' [-Wenum-conversion]
399 | adapter->reset_reason = reset_reason;
| ^
drivers/net/ethernet/amazon/ena/ena_netdev.c: In function 'ena_tx_timeout':
>> drivers/net/ethernet/amazon/ena/ena_netdev.c:106:35: warning: implicit conversion from 'enum ena_regs_reset_reason_types' to 'enum ena_flags_t' [-Wenum-conversion]
106 | ena_reset_device(adapter, ENA_REGS_RESET_OS_NETDEV_WD);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/amazon/ena/ena_netdev.c: In function 'ena_xmit_common':
drivers/net/ethernet/amazon/ena/ena_netdev.c:171:42: warning: implicit conversion from 'enum ena_regs_reset_reason_types' to 'enum ena_flags_t' [-Wenum-conversion]
171 | ENA_REGS_RESET_DRIVER_INVALID_STATE);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/amazon/ena/ena_netdev.c: In function 'handle_invalid_req_id':
drivers/net/ethernet/amazon/ena/ena_netdev.c:1280:41: warning: implicit conversion from 'enum ena_regs_reset_reason_types' to 'enum ena_flags_t' [-Wenum-conversion]
1280 | ena_reset_device(ring->adapter, ENA_REGS_RESET_INV_TX_REQ_ID);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/amazon/ena/ena_netdev.c: In function 'ena_rx_skb':
drivers/net/ethernet/amazon/ena/ena_netdev.c:1444:43: warning: implicit conversion from 'enum ena_regs_reset_reason_types' to 'enum ena_flags_t' [-Wenum-conversion]
1444 | ena_reset_device(adapter, ENA_REGS_RESET_INV_RX_REQ_ID);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/amazon/ena/ena_netdev.c: In function 'ena_clean_rx_irq':
drivers/net/ethernet/amazon/ena/ena_netdev.c:1777:43: warning: implicit conversion from 'enum ena_regs_reset_reason_types' to 'enum ena_flags_t' [-Wenum-conversion]
1777 | ena_reset_device(adapter, ENA_REGS_RESET_TOO_MANY_RX_DESCS);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/amazon/ena/ena_netdev.c:1781:43: warning: implicit conversion from 'enum ena_regs_reset_reason_types' to 'enum ena_flags_t' [-Wenum-conversion]
1781 | ena_reset_device(adapter, ENA_REGS_RESET_INV_RX_REQ_ID);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/amazon/ena/ena_netdev.c: In function 'check_for_rx_interrupt_queue':
drivers/net/ethernet/amazon/ena/ena_netdev.c:3701:43: warning: implicit conversion from 'enum ena_regs_reset_reason_types' to 'enum ena_flags_t' [-Wenum-conversion]
3701 | ena_reset_device(adapter, ENA_REGS_RESET_MISS_INTERRUPT);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/amazon/ena/ena_netdev.c: In function 'check_missing_comp_in_tx_queue':
drivers/net/ethernet/amazon/ena/ena_netdev.c:3738:51: warning: implicit conversion from 'enum ena_regs_reset_reason_types' to 'enum ena_flags_t' [-Wenum-conversion]
3738 | ena_reset_device(adapter, ENA_REGS_RESET_MISS_INTERRUPT);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/amazon/ena/ena_netdev.c:3764:43: warning: implicit conversion from 'enum ena_regs_reset_reason_types' to 'enum ena_flags_t' [-Wenum-conversion]
3764 | ena_reset_device(adapter, ENA_REGS_RESET_MISS_TX_CMPL);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/amazon/ena/ena_netdev.c: In function 'check_for_missing_keep_alive':
drivers/net/ethernet/amazon/ena/ena_netdev.c:3885:43: warning: implicit conversion from 'enum ena_regs_reset_reason_types' to 'enum ena_flags_t' [-Wenum-conversion]
3885 | ena_reset_device(adapter, ENA_REGS_RESET_KEEP_ALIVE_TO);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/amazon/ena/ena_netdev.c: In function 'check_for_admin_com_state':
drivers/net/ethernet/amazon/ena/ena_netdev.c:3896:43: warning: implicit conversion from 'enum ena_regs_reset_reason_types' to 'enum ena_flags_t' [-Wenum-conversion]
3896 | ena_reset_device(adapter, ENA_REGS_RESET_ADMIN_TO);
| ^~~~~~~~~~~~~~~~~~~~~~~
--
In file included from drivers/net/ethernet/amazon/ena/ena_ethtool.c:9:
drivers/net/ethernet/amazon/ena/ena_netdev.h: In function 'ena_reset_device':
>> drivers/net/ethernet/amazon/ena/ena_netdev.h:399:31: warning: implicit conversion from 'enum ena_flags_t' to 'enum ena_regs_reset_reason_types' [-Wenum-conversion]
399 | adapter->reset_reason = reset_reason;
| ^
vim +399 drivers/net/ethernet/amazon/ena/ena_netdev.h
396
397 static inline void ena_reset_device(struct ena_adapter *adapter, enum ena_flags_t reset_reason)
398 {
> 399 adapter->reset_reason = reset_reason;
400 /* Make sure reset reason is set before triggering the reset */
401 smp_mb__before_atomic();
402 set_bit(ENA_FLAG_TRIGGER_RESET, &adapter->flags);
403 }
404
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
prev parent reply other threads:[~2022-01-08 10:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 19:29 [PATCH V1 net-next 00/10] ENA: capabilities field and cosmetic Arthur Kiyanovski
2022-01-06 19:29 ` [PATCH V1 net-next 01/10] net: ena: Change return value of ena_calc_io_queue_size() to void Arthur Kiyanovski
2022-01-06 19:29 ` [PATCH V1 net-next 02/10] net: ena: Add capabilities field with support for ENI stats capability Arthur Kiyanovski
2022-01-06 19:29 ` [PATCH V1 net-next 03/10] net: ena: Change ENI stats support check to use capabilities field Arthur Kiyanovski
2022-01-06 19:29 ` [PATCH V1 net-next 04/10] net: ena: Update LLQ header length in ena documentation Arthur Kiyanovski
2022-01-06 19:29 ` [PATCH V1 net-next 05/10] net: ena: Remove redundant return code check Arthur Kiyanovski
2022-01-06 19:29 ` [PATCH V1 net-next 06/10] net: ena: Move reset completion print to the reset function Arthur Kiyanovski
2022-01-06 19:29 ` [PATCH V1 net-next 07/10] net: ena: Remove ena_calc_queue_size_ctx struct Arthur Kiyanovski
2022-01-06 19:29 ` [PATCH V1 net-next 08/10] net: ena: Add debug prints for invalid req_id resets Arthur Kiyanovski
2022-01-06 19:29 ` [PATCH V1 net-next 09/10] net: ena: Change the name of bad_csum variable Arthur Kiyanovski
2022-01-06 19:29 ` [PATCH V1 net-next 10/10] net: ena: Extract recurring driver reset code into a function Arthur Kiyanovski
2022-01-07 3:00 ` Jakub Kicinski
2022-01-07 20:12 ` Kiyanovski, Arthur
2022-01-07 20:21 ` Jakub Kicinski
2022-01-08 10:33 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202201081810.cbanKMEo-lkp@intel.com \
--to=lkp@intel$(echo .)com \
--cc=akiyano@amazon$(echo .)com \
--cc=aliguori@amazon$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dwmw@amazon$(echo .)com \
--cc=kbuild-all@lists$(echo .)01.org \
--cc=kuba@kernel$(echo .)org \
--cc=matua@amazon$(echo .)com \
--cc=msw@amazon$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=saeedb@amazon$(echo .)com \
--cc=zorik@amazon$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox