From: Zhu Lingshan <lingshan.zhu@intel•com>
To: jasowang@redhat•com, mst@redhat•com
Cc: netdev@vger•kernel.org,
virtualization@lists•linux-foundation.org,
Zhu Lingshan <lingshan.zhu@intel•com>
Subject: [PATCH 6/7] vDPA/ifcvf: implement config interrupt request helper
Date: Mon, 10 Jan 2022 13:19:46 +0800 [thread overview]
Message-ID: <20220110051947.84901-7-lingshan.zhu@intel.com> (raw)
In-Reply-To: <20220110051947.84901-1-lingshan.zhu@intel.com>
This commit implements new helper to request config interrupt by
a given MSIX vector.
Signed-off-by: Zhu Lingshan <lingshan.zhu@intel•com>
---
drivers/vdpa/ifcvf/ifcvf_base.c | 6 ------
drivers/vdpa/ifcvf/ifcvf_main.c | 26 ++++++++++++++++++++++++++
2 files changed, 26 insertions(+), 6 deletions(-)
diff --git a/drivers/vdpa/ifcvf/ifcvf_base.c b/drivers/vdpa/ifcvf/ifcvf_base.c
index fc496d10cf8d..38f91dc6481f 100644
--- a/drivers/vdpa/ifcvf/ifcvf_base.c
+++ b/drivers/vdpa/ifcvf/ifcvf_base.c
@@ -330,12 +330,6 @@ static int ifcvf_hw_enable(struct ifcvf_hw *hw)
ifcvf = vf_to_adapter(hw);
cfg = hw->common_cfg;
- ifc_iowrite16(IFCVF_MSI_CONFIG_OFF, &cfg->msix_config);
-
- if (ifc_ioread16(&cfg->msix_config) == VIRTIO_MSI_NO_VECTOR) {
- IFCVF_ERR(ifcvf->pdev, "No msix vector for device config\n");
- return -EINVAL;
- }
for (i = 0; i < hw->nr_vring; i++) {
if (!hw->vring[i].ready)
diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c
index ce2fbc429fbe..414b5dfd04ca 100644
--- a/drivers/vdpa/ifcvf/ifcvf_main.c
+++ b/drivers/vdpa/ifcvf/ifcvf_main.c
@@ -162,6 +162,32 @@ static int ifcvf_request_vq_irq(struct ifcvf_adapter *adapter, u8 vector_per_vq)
return ret;
}
+static int ifcvf_request_config_irq(struct ifcvf_adapter *adapter, int config_vector)
+{
+ struct pci_dev *pdev = adapter->pdev;
+ struct ifcvf_hw *vf = &adapter->vf;
+ int ret;
+
+ if (!config_vector) {
+ IFCVF_INFO(pdev, "No config interrupt because of no vectors\n");
+ vf->config_irq = -EINVAL;
+ return 0;
+ }
+
+ snprintf(vf->config_msix_name, 256, "ifcvf[%s]-config\n",
+ pci_name(pdev));
+ vf->config_irq = pci_irq_vector(pdev, config_vector);
+ ret = devm_request_irq(&pdev->dev, vf->config_irq,
+ ifcvf_config_changed, 0,
+ vf->config_msix_name, vf);
+ if (ret) {
+ IFCVF_ERR(pdev, "Failed to request config irq\n");
+ return ret;
+ }
+ ifcvf_set_config_vector(vf, config_vector);
+
+ return 0;
+}
static int ifcvf_request_irq(struct ifcvf_adapter *adapter)
{
--
2.27.0
next prev parent reply other threads:[~2022-01-10 5:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 5:19 [PATCH 0/7] Supoort shared irq for virtqueues Zhu Lingshan
2022-01-10 5:19 ` [PATCH 1/7] vDPA/ifcvf: implement IO read/write helpers in the header file Zhu Lingshan
2022-01-10 5:19 ` [PATCH 2/7] vDPA/ifcvf: introduce new helpers to set config vector and vq vectors Zhu Lingshan
2022-01-10 5:19 ` [PATCH 3/7] vDPA/ifcvf: implement device MSIX vector allocation helper Zhu Lingshan
2022-01-10 5:19 ` [PATCH 4/7] vDPA/ifcvf: implement shared irq handlers for vqs Zhu Lingshan
2022-01-10 5:19 ` [PATCH 5/7] vDPA/ifcvf: irq request helpers for both shared and per_vq irq Zhu Lingshan
2022-01-10 5:19 ` Zhu Lingshan [this message]
2022-01-10 5:19 ` [PATCH 7/7] vDPA/ifcvf: improve irq requester, to handle per_vq/shared/config irq Zhu Lingshan
-- strict thread matches above, loose matches on Subject: below --
2022-01-10 5:18 [PATCH 0/7] Supoort shared irq for virtqueues Zhu Lingshan
2022-01-10 5:18 ` [PATCH 6/7] vDPA/ifcvf: implement config interrupt request helper Zhu Lingshan
2022-01-10 6:07 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220110051947.84901-7-lingshan.zhu@intel.com \
--to=lingshan.zhu@intel$(echo .)com \
--cc=jasowang@redhat$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=virtualization@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox