From: JaeMan Park <jaeman@google•com>
To: unlisted-recipients:; (no To-header on input)
Cc: johannes@sipsolutions•net, linux-wireless@vger•kernel.org,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
adelva@google•com, kernel-team@android•com,
JaeMan Park <jaeman@google•com>
Subject: [PATCH] mac80211_hwsim: initialize ieee80211_tx_info at hw_scan_work
Date: Thu, 13 Jan 2022 15:02:35 +0900 [thread overview]
Message-ID: <20220113060235.546107-1-jaeman@google.com> (raw)
In mac80211_hwsim, the probe_req frame is created and sent while
scanning. It is sent with ieee80211_tx_info which is not initialized.
Uninitialized ieee80211_tx_info can cause problems when using
mac80211_hwsim with wmediumd. wmediumd checks the tx_rates field of
ieee80211_tx_info and doesn't relay probe_req frame to other clients
even if it is a broadcasting message.
Call ieee80211_tx_prepare_skb() to initialize ieee80211_tx_info for
the probe_req that is created by hw_scan_work in mac80211_hwsim.
Signed-off-by: JaeMan Park <jaeman@google•com>
---
drivers/net/wireless/mac80211_hwsim.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c
index 0307a6677907..95f1e4899231 100644
--- a/drivers/net/wireless/mac80211_hwsim.c
+++ b/drivers/net/wireless/mac80211_hwsim.c
@@ -2336,6 +2336,13 @@ static void hw_scan_work(struct work_struct *work)
if (req->ie_len)
skb_put_data(probe, req->ie, req->ie_len);
+ if (!ieee80211_tx_prepare_skb(hwsim->hw,
+ hwsim->hw_scan_vif,
+ probe,
+ hwsim->tmp_chan->band,
+ NULL))
+ continue;
+
local_bh_disable();
mac80211_hwsim_tx_frame(hwsim->hw, probe,
hwsim->tmp_chan);
--
2.34.1.703.g22d0c6ccf7-goog
next reply other threads:[~2022-01-13 6:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 6:02 JaeMan Park [this message]
2022-01-26 6:56 ` [PATCH] mac80211_hwsim: initialize ieee80211_tx_info at hw_scan_work JaeMan Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220113060235.546107-1-jaeman@google.com \
--to=jaeman@google$(echo .)com \
--cc=adelva@google$(echo .)com \
--cc=johannes@sipsolutions$(echo .)net \
--cc=kernel-team@android$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox