public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

* [PATCH] lib82596: Fix IRQ check in sni_82596_probe
@ 2022-01-14  6:57 Miaoqian Lin
  2022-01-14 11:30 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2022-01-14  6:57 UTC (permalink / raw)
  To: David S. Miller, Jakub Kicinski, Miaoqian Lin, Jeff Kirsher,
	netdev, linux-kernel

platform_get_irq() returns negative error number instead 0 on failure.
And the doc of platform_get_irq() provides a usage example:

    int irq = platform_get_irq(pdev, 0);
    if (irq < 0)
        return irq;

Fix the check of return value to catch errors correctly.

Fixes: 115978859272 ("i825xx: Move the Intel 82586/82593/82596 based drivers")
Signed-off-by: Miaoqian Lin <linmq006@gmail•com>
---
 drivers/net/ethernet/i825xx/sni_82596.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/i825xx/sni_82596.c b/drivers/net/ethernet/i825xx/sni_82596.c
index 27937c5d7956..daec9ce04531 100644
--- a/drivers/net/ethernet/i825xx/sni_82596.c
+++ b/drivers/net/ethernet/i825xx/sni_82596.c
@@ -117,9 +117,10 @@ static int sni_82596_probe(struct platform_device *dev)
 	netdevice->dev_addr[5] = readb(eth_addr + 0x06);
 	iounmap(eth_addr);
 
-	if (!netdevice->irq) {
+	if (netdevice->irq < 0) {
 		printk(KERN_ERR "%s: IRQ not found for i82596 at 0x%lx\n",
 			__FILE__, netdevice->base_addr);
+		retval = netdevice->irq;
 		goto probe_failed;
 	}
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

• * Re: [PATCH] lib82596: Fix IRQ check in sni_82596_probe
    2022-01-14  6:57 [PATCH] lib82596: Fix IRQ check in sni_82596_probe Miaoqian Lin
  @ 2022-01-14 11:30 ` patchwork-bot+netdevbpf
    0 siblings, 0 replies; 2+ messages in thread
  From: patchwork-bot+netdevbpf @ 2022-01-14 11:30 UTC (permalink / raw)
    To: Miaoqian Lin; +Cc: davem, kuba, jeffrey.t.kirsher, netdev, linux-kernel
  
  Hello:
  
  This patch was applied to netdev/net.git (master)
  by David S. Miller <davem@davemloft•net>:
  
  On Fri, 14 Jan 2022 06:57:24 +0000 you wrote:
  > platform_get_irq() returns negative error number instead 0 on failure.
  > And the doc of platform_get_irq() provides a usage example:
  > 
  >     int irq = platform_get_irq(pdev, 0);
  >     if (irq < 0)
  >         return irq;
  > 
  > [...]
  
  Here is the summary with links:
    - lib82596: Fix IRQ check in sni_82596_probe
      https://git.kernel.org/netdev/net/c/99218cbf81bf
  
  You are awesome, thank you!
  -- 
  Deet-doot-dot, I am a bot.
  https://korg.docs.kernel.org/patchwork/pwbot.html
  
  
  
  ^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-01-14 11:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-14  6:57 [PATCH] lib82596: Fix IRQ check in sni_82596_probe Miaoqian Lin
2022-01-14 11:30 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox