Subject: Re: [PATCH iproute2 v4 2/2] tc: u32: add json support in `print_raw`, `print_ipv4`, `print_ipv6`

From: Stephen Hemminger <[email-masked]>
Date: Mon, 17 Jan 2022 20:32:54 -0800

On Mon, 17 Jan 2022 21:42:21 -0500
Wen Liang <[email-masked]> wrote:

> Signed-off-by: Wen Liang <[email-masked]>

More checkpatch warnings, please fix.

WARNING: Missing commit description - Add an appropriate one

WARNING: suspect code indent for conditional statements (24, 33)
#100: FILE: tc/f_u32.c:855:
 			if (bits >= 0) {
+				 const char *addr;

WARNING: Statements should start on a tabstop
#106: FILE: tc/f_u32.c:856:
+				 const char *addr;

WARNING: Statements should start on a tabstop
#107: FILE: tc/f_u32.c:857:
+				 if (key->off == 12) {

WARNING: Missing a blank line after declarations
#107: FILE: tc/f_u32.c:857:
+				 const char *addr;
+				 if (key->off == 12) {

WARNING: suspect code indent for conditional statements (33, 39)
#107: FILE: tc/f_u32.c:857:
+				 if (key->off == 12) {
+				       print_nl();

WARNING: Statements should start on a tabstop
#111: FILE: tc/f_u32.c:861:
+				 } else {

WARNING: suspect code indent for conditional statements (33, 39)
#111: FILE: tc/f_u32.c:861:
+				 } else {
+				       print_nl();

WARNING: Statements should start on a tabstop
#115: FILE: tc/f_u32.c:865:
+				 }

WARNING: Missing a blank line after declarations
#200: FILE: tc/f_u32.c:933:
+				const char *addr;
+				if (key->off == 12) {

WARNING: suspect code indent for conditional statements (32, 38)
#200: FILE: tc/f_u32.c:933:
+				if (key->off == 12) {
+			              print_nl();

ERROR: code indent should use tabs where possible
#201: FILE: tc/f_u32.c:934:
+^I^I^I              print_nl();$

WARNING: suspect code indent for conditional statements (32, 38)
#204: FILE: tc/f_u32.c:937:
+				} else {
+			              print_nl();

ERROR: code indent should use tabs where possible
#205: FILE: tc/f_u32.c:938:
+^I^I^I              print_nl();$

total: 2 errors, 12 warnings, 198 lines checked