From: Raju Rangoju <Raju.Rangoju@amd•com>
To: <thomas.lendacky@amd•com>, <davem@davemloft•net>, <kuba@kernel•org>
Cc: <netdev@vger•kernel.org>, <Shyam-sundar.S-k@amd•com>,
<Sudheesh.Mavila@amd•com>, <Raju.Rangoju@amd•com>,
Sudheesh Mavila <sudheesh.mavila@amd•com>
Subject: [PATCH net] net:amd-xgbe: ensure to reset the tx_timer_active flag
Date: Thu, 27 Jan 2022 11:32:22 +0530 [thread overview]
Message-ID: <20220127060222.453371-1-Raju.Rangoju@amd.com> (raw)
Ensure to reset the tx_timer_active flag in xgbe_stop(),
otherwise a port restart may result in tx timeout due to
uncleared flag.
Fixes: c635eaacbf77 ("amd-xgbe: Remove Tx coalescing")
Co-developed-by: Sudheesh Mavila <sudheesh.mavila@amd•com>
Signed-off-by: Sudheesh Mavila <sudheesh.mavila@amd•com>
Signed-off-by: Raju Rangoju <Raju.Rangoju@amd•com>
---
drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
index 492ac383f16d..4949ba69c097 100644
--- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
+++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
@@ -721,7 +721,9 @@ static void xgbe_stop_timers(struct xgbe_prv_data *pdata)
if (!channel->tx_ring)
break;
+ /* Deactivate the Tx timer */
del_timer_sync(&channel->tx_timer);
+ channel->tx_timer_active = 0;
}
}
--
2.25.1
next reply other threads:[~2022-01-27 6:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 6:02 Raju Rangoju [this message]
2022-01-27 14:46 ` [PATCH net] net:amd-xgbe: ensure to reset the tx_timer_active flag Tom Lendacky
2022-01-28 3:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220127060222.453371-1-Raju.Rangoju@amd.com \
--to=raju.rangoju@amd$(echo .)com \
--cc=Shyam-sundar.S-k@amd$(echo .)com \
--cc=Sudheesh.Mavila@amd$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=thomas.lendacky@amd$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox