Subject: Re: [PATCH iproute2-next 2/2] f_flower: Implement gtp options support

From: Stephen Hemminger <[email-masked]>
Date: Thu, 27 Jan 2022 09:15:41 -0800

On Thu, 27 Jan 2022 14:13:55 +0100
Wojciech Drewek <[email-masked]> wrote:

> +	open_json_array(PRINT_JSON, name);
> +	open_json_object(NULL);
> +	print_uint(PRINT_JSON, "pdu_type", NULL, pdu_type);
> +	print_uint(PRINT_JSON, "qfi", NULL, qfi);
> +	close_json_object();
> +	close_json_array(PRINT_JSON, name);
> +
> +	sprintf(strbuf, "%02x:%02x", pdu_type, qfi);

Doing JSON specific code is not necessary here?
And why an array of two named elements? Seems confusing