public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Tianyu Lan <ltykernel@gmail•com>
To: kys@microsoft•com, haiyangz@microsoft•com,
	sthemmin@microsoft•com, wei.liu@kernel•org, decui@microsoft•com,
	tglx@linutronix•de, mingo@redhat•com, bp@alien8•de,
	dave.hansen@linux•intel.com, x86@kernel•org, hpa@zytor•com,
	davem@davemloft•net, kuba@kernel•org, hch@infradead•org,
	m.szyprowski@samsung•com, robin.murphy@arm•com,
	michael.h.kelley@microsoft•com
Cc: Tianyu Lan <Tianyu.Lan@microsoft•com>,
	iommu@lists•linux-foundation.org, linux-hyperv@vger•kernel.org,
	linux-kernel@vger•kernel.org, netdev@vger•kernel.org
Subject: [PATCH] Netvsc: Call hv_unmap_memory() in the netvsc_device_remove()
Date: Tue,  1 Feb 2022 11:32:11 -0500	[thread overview]
Message-ID: <20220201163211.467423-1-ltykernel@gmail.com> (raw)

From: Tianyu Lan <Tianyu.Lan@microsoft•com>

netvsc_device_remove() calls vunmap() inside which should not be
called in the interrupt context. Current code calls hv_unmap_memory()
in the free_netvsc_device() which is rcu callback and maybe called
in the interrupt context. This will trigger BUG_ON(in_interrupt())
in the vunmap(). Fix it via moving hv_unmap_memory() to netvsc_device_
remove().

Fixes: 846da38de0e8 ("net: netvsc: Add Isolation VM support for netvsc driver")
Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft•com>
---
 drivers/net/hyperv/netvsc.c | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
index afa81a9480cc..f989f920d4ce 100644
--- a/drivers/net/hyperv/netvsc.c
+++ b/drivers/net/hyperv/netvsc.c
@@ -154,19 +154,15 @@ static void free_netvsc_device(struct rcu_head *head)
 
 	kfree(nvdev->extension);
 
-	if (nvdev->recv_original_buf) {
-		hv_unmap_memory(nvdev->recv_buf);
+	if (nvdev->recv_original_buf)
 		vfree(nvdev->recv_original_buf);
-	} else {
+	else
 		vfree(nvdev->recv_buf);
-	}
 
-	if (nvdev->send_original_buf) {
-		hv_unmap_memory(nvdev->send_buf);
+	if (nvdev->send_original_buf)
 		vfree(nvdev->send_original_buf);
-	} else {
+	else
 		vfree(nvdev->send_buf);
-	}
 
 	bitmap_free(nvdev->send_section_map);
 
@@ -765,6 +761,12 @@ void netvsc_device_remove(struct hv_device *device)
 		netvsc_teardown_send_gpadl(device, net_device, ndev);
 	}
 
+	if (net_device->recv_original_buf)
+		hv_unmap_memory(net_device->recv_buf);
+
+	if (net_device->send_original_buf)
+		hv_unmap_memory(net_device->send_buf);
+
 	/* Release all resources */
 	free_netvsc_device_rcu(net_device);
 }
-- 
2.25.1

next             reply	other threads:[~2022-02-01 16:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01 16:32 Tianyu Lan [this message]
2022-02-01 23:20 ` [PATCH] Netvsc: Call hv_unmap_memory() in the netvsc_device_remove() Haiyang Zhang
2022-02-02 17:05 ` Michael Kelley (LINUX)
2022-02-08 14:19   ` Tianyu Lan

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:afa81a9480c dfblob:f989f920d4c )
 OR (
bs:"[PATCH] Netvsc: Call hv_unmap_memory() in the netvsc_device_remove()" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220201163211.467423-1-ltykernel@gmail.com \
    --to=ltykernel@gmail$(echo .)com \
    --cc=Tianyu.Lan@microsoft$(echo .)com \
    --cc=bp@alien8$(echo .)de \
    --cc=dave.hansen@linux$(echo .)intel.com \
    --cc=davem@davemloft$(echo .)net \
    --cc=decui@microsoft$(echo .)com \
    --cc=haiyangz@microsoft$(echo .)com \
    --cc=hch@infradead$(echo .)org \
    --cc=hpa@zytor$(echo .)com \
    --cc=iommu@lists$(echo .)linux-foundation.org \
    --cc=kuba@kernel$(echo .)org \
    --cc=kys@microsoft$(echo .)com \
    --cc=linux-hyperv@vger$(echo .)kernel.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=m.szyprowski@samsung$(echo .)com \
    --cc=michael.h.kelley@microsoft$(echo .)com \
    --cc=mingo@redhat$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=robin.murphy@arm$(echo .)com \
    --cc=sthemmin@microsoft$(echo .)com \
    --cc=tglx@linutronix$(echo .)de \
    --cc=wei.liu@kernel$(echo .)org \
    --cc=x86@kernel$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox