From: Paul Chaignon <paul@isovalent•com>
To: David Ahern <dsahern@gmail•com>, netdev@vger•kernel.org
Cc: Stephen Hemminger <stephen@networkplumber•org>,
Hangbin Liu <haliu@redhat•com>
Subject: Re: [PATCH iproute2] lib/bpf: Fix log level in verbose mode with libbpf
Date: Wed, 2 Feb 2022 22:07:05 +0100 [thread overview]
Message-ID: <20220202210705.GB96712@Mem> (raw)
In-Reply-To: <c40e7fc2-e395-6999-9967-3e76e0bcfd3f@gmail.com>
On Wed, Feb 02, 2022 at 12:10:03PM -0700, David Ahern wrote:
> On 2/2/22 11:11 AM, Paul Chaignon wrote:
> > diff --git a/lib/bpf_libbpf.c b/lib/bpf_libbpf.c
> > index 50ef16bd..bb6399bf 100644
> > --- a/lib/bpf_libbpf.c
> > +++ b/lib/bpf_libbpf.c
> > @@ -305,7 +305,7 @@ static int load_bpf_object(struct bpf_cfg_in *cfg)
> >
> > attr.obj = obj;
> > if (cfg->verbose)
> > - attr.log_level = 2;
> > + attr.log_level = 1;
> >
> > ret = bpf_object__load_xattr(&attr);
> > if (ret)
>
> ip and tc do not have verbosity flags, but there is show_details. Why
> not tie the log_level to that?
I'm not sure I understand what you're proposing. This code is referring
to the "verbose" parameter of the tc filter command, as in e.g.:
tc filter replace dev eth0 ingress bpf da obj prog.o sec sec1 verbose
Are you proposing we replace that parameter with the existing -details
option?
next prev parent reply other threads:[~2022-02-02 21:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 18:11 [PATCH iproute2] lib/bpf: Fix log level in verbose mode with libbpf Paul Chaignon
2022-02-02 19:10 ` David Ahern
2022-02-02 21:07 ` Paul Chaignon [this message]
2022-02-02 21:53 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220202210705.GB96712@Mem \
--to=paul@isovalent$(echo .)com \
--cc=dsahern@gmail$(echo .)com \
--cc=haliu@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox