From: Stephen Hemminger <stephen@networkplumber•org>
To: Gal Pressman <gal@nvidia•com>
Cc: David Ahern <dsahern@gmail•com>, <netdev@vger•kernel.org>
Subject: Re: [PATCH iproute2-next] tunnel: Fix missing space after local/remote print
Date: Tue, 8 Feb 2022 09:57:29 -0800 [thread overview]
Message-ID: <20220208095729.35701fd7@hermes.local> (raw)
In-Reply-To: <20220208144005.32401-1-gal@nvidia.com>
On Tue, 8 Feb 2022 16:40:05 +0200
Gal Pressman <gal@nvidia•com> wrote:
> The cited commit removed the space after the local/remote tunnel print
> and resulted in "broken" output:
>
> gre remote 1.1.1.2local 1.1.1.1ttl inherit erspan_ver 0 addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> Fixes: 5632cf69ad59 ("tunnel: fix clang warning")
> Signed-off-by: Gal Pressman <gal@nvidia•com>
> ---
> ip/tunnel.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/ip/tunnel.c b/ip/tunnel.c
> index f2632f43babf..7200ce831317 100644
> --- a/ip/tunnel.c
> +++ b/ip/tunnel.c
> @@ -299,6 +299,8 @@ void tnl_print_endpoint(const char *name, const struct rtattr *rta, int family)
> }
>
> print_string_name_value(name, value);
> + if (!is_json_context())
> + print_string(PRINT_FP, NULL, " ", NULL);
is_json_context is not needed here.
next prev parent reply other threads:[~2022-02-08 17:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 14:40 [PATCH iproute2-next] tunnel: Fix missing space after local/remote print Gal Pressman
2022-02-08 17:57 ` Stephen Hemminger [this message]
2022-02-09 6:51 ` Gal Pressman
-- strict thread matches above, loose matches on Subject: below --
2022-02-09 6:54 Gal Pressman
2022-02-10 18:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220208095729.35701fd7@hermes.local \
--to=stephen@networkplumber$(echo .)org \
--cc=dsahern@gmail$(echo .)com \
--cc=gal@nvidia$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox