From: Matt Johnston <matt@codeconstruct•com.au>
To: netdev@vger•kernel.org
Cc: "David S. Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>,
Jeremy Kerr <jk@codeconstruct•com.au>
Subject: [PATCH net-next] mctp: Fix warnings reported by clang-analyzer
Date: Tue, 22 Feb 2022 12:29:36 +0800 [thread overview]
Message-ID: <20220222042936.516874-1-matt@codeconstruct.com.au> (raw)
net/mctp/device.c:140:11: warning: Assigned value is garbage or undefined
[clang-analyzer-core.uninitialized.Assign]
mcb->idx = idx;
- Not a real problem due to how the callback runs, fix the warning.
net/mctp/route.c:458:4: warning: Value stored to 'msk' is never read
[clang-analyzer-deadcode.DeadStores]
msk = container_of(key->sk, struct mctp_sock, sk);
- 'msk' dead assignment can be removed here.
Signed-off-by: Matt Johnston <matt@codeconstruct•com.au>
---
net/mctp/device.c | 2 +-
net/mctp/route.c | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/mctp/device.c b/net/mctp/device.c
index 9e097e61f23a..224f067e9d4c 100644
--- a/net/mctp/device.c
+++ b/net/mctp/device.c
@@ -107,7 +107,7 @@ static int mctp_dump_addrinfo(struct sk_buff *skb, struct netlink_callback *cb)
struct ifaddrmsg *hdr;
struct mctp_dev *mdev;
int ifindex;
- int idx, rc;
+ int idx = 0, rc;
hdr = nlmsg_data(cb->nlh);
// filter by ifindex if requested
diff --git a/net/mctp/route.c b/net/mctp/route.c
index fe6c8bf1ec2c..85acfcbabd9c 100644
--- a/net/mctp/route.c
+++ b/net/mctp/route.c
@@ -456,7 +456,6 @@ static int mctp_route_input(struct mctp_route *route, struct sk_buff *skb)
* the reassembly/response key
*/
if (!rc && flags & MCTP_HDR_FLAG_EOM) {
- msk = container_of(key->sk, struct mctp_sock, sk);
sock_queue_rcv_skb(key->sk, key->reasm_head);
key->reasm_head = NULL;
__mctp_key_done_in(key, net, f, MCTP_TRACE_KEY_REPLIED);
--
2.32.0
next reply other threads:[~2022-02-22 4:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 4:29 Matt Johnston [this message]
2022-02-23 12:40 ` [PATCH net-next] mctp: Fix warnings reported by clang-analyzer patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220222042936.516874-1-matt@codeconstruct.com.au \
--to=matt@codeconstruct$(echo .)com.au \
--cc=davem@davemloft$(echo .)net \
--cc=jk@codeconstruct$(echo .)com.au \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox