From: Pavel Machek <pavel@ucw•cz>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix•de>
Cc: "Mark Brown" <broonie@kernel•org>,
"Marek Behún" <kabel@kernel•org>,
"Peter Huewe" <peterhuewe@gmx•de>,
"Jarkko Sakkinen" <jarkko@kernel•org>,
"Jason Gunthorpe" <jgg@ziepe•ca>,
"Michael Turquette" <mturquette@baylibre•com>,
"Stephen Boyd" <sboyd@kernel•org>,
"Linus Walleij" <linus.walleij@linaro•org>,
"Bartosz Golaszewski" <brgl@bgdev•pl>,
"Thierry Reding" <thierry.reding@gmail•com>,
"Sam Ravnborg" <sam@ravnborg•org>,
"David Airlie" <airlied@linux•ie>,
"Daniel Vetter" <daniel@ffwll•ch>,
"Markuss Broks" <markuss.broks@gmail•com>,
"Emma Anholt" <emma@anholt•net>,
"David Lechner" <david@lechnology•com>,
"Kamlesh Gurudasani" <kamlesh.gurudasani@gmail•com>,
"Noralf Trønnes" <noralf@tronnes•org>,
"Jean Delvare" <jdelvare@suse•com>,
"Guenter Roeck" <linux@roeck-us•net>,
"Dan Robertson" <dan@dlrobertson•com>,
"Jonathan Cameron" <jic23@kernel•org>,
"Lars-Peter Clausen" <lars@metafoo•de>,
"Michael Hennerich" <Michael.Hennerich@analog•com>,
"Marcus Folkesson" <marcus.folkesson@gmail•com>,
"Kent Gustavsson" <kent@minoris•se>,
"Rui Miguel Silva" <rmfrfs@gmail•com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail•com>,
"Yasunari Takiguchi" <Yasunari.Takiguchi@sony•com>,
"Mauro Carvalho Chehab" <mchehab@kernel•org>,
"Charles-Antoine Couret" <charles-antoine.couret@nexvision•fr>,
"Antti Palosaari" <crope@iki•fi>,
"Lee Jones" <lee.jones@linaro•org>,
"Support Opensource" <support.opensource@diasemi•com>,
"Charles Keepax" <ckeepax@opensource•cirrus.com>,
"Richard Fitzgerald" <rf@opensource•cirrus.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail•com>,
"Alexandre Torgue" <alexandre.torgue@foss•st.com>,
"Arnd Bergmann" <arnd@arndb•de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation•org>,
"Eric Piel" <eric.piel@tremplin-utc•net>,
"Ulf Hansson" <ulf.hansson@linaro•org>,
"Miquel Raynal" <miquel.raynal@bootlin•com>,
"Richard Weinberger" <richard@nod•at>,
"Vignesh Raghavendra" <vigneshr@ti•com>,
"Wolfgang Grandegger" <wg@grandegger•com>,
"Marc Kleine-Budde" <mkl@pengutronix•de>,
"David S. Miller" <davem@davemloft•net>,
"Jakub Kicinski" <kuba@kernel•org>,
"Manivannan Sadhasivam" <mani@kernel•org>,
"Thomas Kopp" <thomas.kopp@microchip•com>,
"Florian Fainelli" <f.fainelli@gmail•com>,
"Andrew Lunn" <andrew@lunn•ch>,
"Vivien Didelot" <vivien.didelot@gmail•com>,
"Vladimir Oltean" <olteanv@gmail•com>,
"Woojung Huh" <woojung.huh@microchip•com>,
UNGLinuxDriver@microchip•com,
"Łukasz Stelmach" <l.stelmach@samsung•com>,
"Alexander Aring" <alex.aring@gmail•com>,
"Stefan Schmidt" <stefan@datenfreihafen•org>,
"Harry Morris" <h.morris@cascoda•com>,
"Varka Bhadram" <varkabhadram@gmail•com>,
"Xue Liu" <liuxuenetmail@gmail•com>,
"Alan Ott" <alan@signal11•us>,
"Heiner Kallweit" <hkallweit1@gmail•com>,
"Russell King" <linux@armlinux•org.uk>,
"Christian Lamparter" <chunkeey@googlemail•com>,
"Kalle Valo" <kvalo@kernel•org>,
"Ajay Singh" <ajay.kathat@microchip•com>,
"Claudiu Beznea" <claudiu.beznea@microchip•com>,
"Solomon Peachy" <pizza@shaftnet•org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical•com>,
"Mark Greer" <mgreer@animalcreek•com>,
"Benson Leung" <bleung@chromium•org>,
"Hans de Goede" <hdegoede@redhat•com>,
"Mark Gross" <markgross@kernel•org>,
"Alessandro Zummo" <a.zummo@towertech•it>,
"Alexandre Belloni" <alexandre.belloni@bootlin•com>,
"Jérôme Pouiller" <jerome.pouiller@silabs•com>,
"Jiri Slaby" <jirislaby@kernel•org>,
"Felipe Balbi" <balbi@kernel•org>,
"Daniel Thompson" <daniel.thompson@linaro•org>,
"Jingoo Han" <jingoohan1@gmail•com>,
"Helge Deller" <deller@gmx•de>,
"James Schulman" <james.schulman@cirrus•com>,
"David Rhodes" <david.rhodes@cirrus•com>,
"Lucas Tanure" <tanureal@opensource•cirrus.com>,
"Jaroslav Kysela" <perex@perex•cz>,
"Takashi Iwai" <tiwai@suse•com>, "Nuno Sá" <nuno.sa@analog•com>,
"Liam Girdwood" <lgirdwood@gmail•com>,
"Daniel Mack" <daniel@zonque•org>,
"Thomas Zimmermann" <tzimmermann@suse•de>,
"Maxime Ripard" <mripard@kernel•org>,
"Andy Shevchenko" <andriy.shevchenko@linux•intel.com>,
"Stephan Gerhold" <stephan@gerhold•net>,
"Alexandru Ardelean" <ardeleanalex@gmail•com>,
"Mike Looijmans" <mike.looijmans@topic•nl>,
"Gwendal Grignou" <gwendal@chromium•org>,
"Cai Huoqing" <caihuoqing@baidu•com>,
"Minghao Chi" <chi.minghao@zte•com.cn>,
"Antoniu Miclaus" <antoniu.miclaus@analog•com>,
"Julia Lawall" <Julia.Lawall@inria•fr>,
"Ronald Tschalär" <ronald@innovation•ch>,
"Marco Felsch" <m.felsch@pengutronix•de>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx•net>,
"Emmanuel Gil Peyrot" <linkmauve@linkmauve•fr>,
"Jon Hunter" <jonathanh@nvidia•com>,
"Andrew Morton" <akpm@linux-foundation•org>,
"Heiko Schocher" <hs@denx•de>,
"Fabio Estevam" <festevam@gmail•com>,
"Colin Ian King" <colin.king@intel•com>,
"Dan Carpenter" <dan.carpenter@oracle•com>,
"Tudor Ambarus" <tudor.ambarus@microchip•com>,
"Matt Kline" <matt@bitbashing•io>,
"Torin Cooper-Bennun" <torin@maxiluxsystems•com>,
"Vincent Mailhol" <mailhol.vincent@wanadoo•fr>,
"Stefan Mätje" <stefan.maetje@esd•eu>,
"Frieder Schrempf" <frieder.schrempf@kontron•de>,
"Wei Yongjun" <weiyongjun1@huawei•com>,
"Randy Dunlap" <rdunlap@infradead•org>,
"Nanyong Sun" <sunnanyong@huawei•com>,
"Yang Shen" <shenyang39@huawei•com>,
dingsenjie <dingsenjie@yulong•com>,
"Aditya Srivastava" <yashsri421@gmail•com>,
"Stefan Wahren" <stefan.wahren@i2se•com>,
"Peter Zijlstra" <peterz@infradead•org>,
"Michael Walle" <michael@walle•cc>,
"Yang Li" <yang.lee@linux•alibaba.com>,
"Geert Uytterhoeven" <geert+renesas@glider•be>,
wengjianfeng <wengjianfeng@yulong•com>,
"Sidong Yang" <realwakka@gmail•com>,
"Paulo Miguel Almeida" <paulo.miguel.almeida.rodenas@gmail•com>,
"Zhang Qilong" <zhangqilong3@huawei•com>,
"Will Deacon" <will@kernel•org>,
"Mark Tomlinson" <mark.tomlinson@alliedtelesis•co.nz>,
"Davidlohr Bueso" <dbueso@suse•de>, "Claudius Heine" <ch@denx•de>,
"Jiri Prchal" <jiri.prchal@aksignal•cz>,
linux-kernel@vger•kernel.org, linux-integrity@vger•kernel.org,
linux-clk@vger•kernel.org, linux-gpio@vger•kernel.org,
dri-devel@lists•freedesktop.org, linux-hwmon@vger•kernel.org,
linux-iio@vger•kernel.org, linux-input@vger•kernel.org,
linux-leds@vger•kernel.org, linux-media@vger•kernel.org,
patches@opensource•cirrus.com, alsa-devel@alsa-project•org,
linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org, linux-mmc@vger•kernel.org,
linux-mtd@lists•infradead.org, linux-can@vger•kernel.org,
netdev@vger•kernel.org, linux-wpan@vger•kernel.org,
linux-wireless@vger•kernel.org, libertas-dev@lists•infradead.org,
platform-driver-x86@vger•kernel.org, linux-rtc@vger•kernel.org,
linux-spi@vger•kernel.org, linux-fbdev@vger•kernel.org,
linux-staging@lists•linux.dev, linux-serial@vger•kernel.org,
linux-usb@vger•kernel.org, linux-omap@vger•kernel.org,
kernel@pengutronix•de
Subject: Re: [PATCH 5/5] spi: make remove callback a void function
Date: Wed, 2 Mar 2022 08:30:16 +0100 [thread overview]
Message-ID: <20220302073016.GB32222@amd> (raw)
In-Reply-To: <20220123175201.34839-6-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 599 bytes --]
Hi!
> The value returned by an spi driver's remove function is mostly ignored.
> (Only an error message is printed if the value is non-zero that the
> error is ignored.)
>
> So change the prototype of the remove function to return no value. This
> way driver authors are not tempted to assume that passing an error to
> the upper layer is a good idea. All drivers are adapted accordingly.
> There is no intended change of behaviour, all callbacks were prepared to
> return 0 before.
Acked-by: Pavel Machek <pavel@ucw•cz>
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2022-03-02 7:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 17:51 [PATCH 0/5] spi: make remove callback a void function Uwe Kleine-König
2022-01-23 17:52 ` [PATCH 5/5] " Uwe Kleine-König
2022-01-23 22:49 ` Marc Kleine-Budde
2022-01-24 12:23 ` Andy Shevchenko
2022-01-25 9:35 ` Alexandre Belloni
2022-01-25 9:44 ` Stefan Schmidt
2022-01-25 9:47 ` Jonathan Cameron
2022-01-25 10:29 ` Uwe Kleine-König
2022-01-25 10:19 ` Miquel Raynal
2022-01-25 10:25 ` Claudius Heine
2022-01-25 10:37 ` Geert Uytterhoeven
2022-01-25 12:43 ` Lukasz Stelmach
2022-02-08 13:39 ` Mark Brown
2022-02-18 12:37 ` Hans Verkuil
2022-03-02 7:30 ` Pavel Machek [this message]
2022-01-25 9:30 ` [PATCH 0/5] " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220302073016.GB32222@amd \
--to=pavel@ucw$(echo .)cz \
--cc=Julia.Lawall@inria$(echo .)fr \
--cc=Michael.Hennerich@analog$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=Yasunari.Takiguchi@sony$(echo .)com \
--cc=a.zummo@towertech$(echo .)it \
--cc=airlied@linux$(echo .)ie \
--cc=ajay.kathat@microchip$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alan@signal11$(echo .)us \
--cc=alex.aring@gmail$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=antoniu.miclaus@analog$(echo .)com \
--cc=ardeleanalex@gmail$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=balbi@kernel$(echo .)org \
--cc=bleung@chromium$(echo .)org \
--cc=brgl@bgdev$(echo .)pl \
--cc=broonie@kernel$(echo .)org \
--cc=caihuoqing@baidu$(echo .)com \
--cc=ch@denx$(echo .)de \
--cc=charles-antoine.couret@nexvision$(echo .)fr \
--cc=chi.minghao@zte$(echo .)com.cn \
--cc=chunkeey@googlemail$(echo .)com \
--cc=ckeepax@opensource$(echo .)cirrus.com \
--cc=claudiu.beznea@microchip$(echo .)com \
--cc=colin.king@intel$(echo .)com \
--cc=crope@iki$(echo .)fi \
--cc=dan.carpenter@oracle$(echo .)com \
--cc=dan@dlrobertson$(echo .)com \
--cc=daniel.thompson@linaro$(echo .)org \
--cc=daniel@ffwll$(echo .)ch \
--cc=daniel@zonque$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=david.rhodes@cirrus$(echo .)com \
--cc=david@lechnology$(echo .)com \
--cc=dbueso@suse$(echo .)de \
--cc=deller@gmx$(echo .)de \
--cc=dingsenjie@yulong$(echo .)com \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=emma@anholt$(echo .)net \
--cc=eric.piel@tremplin-utc$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=festevam@gmail$(echo .)com \
--cc=frieder.schrempf@kontron$(echo .)de \
--cc=geert+renesas@glider$(echo .)be \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=gwendal@chromium$(echo .)org \
--cc=h.morris@cascoda$(echo .)com \
--cc=hdegoede@redhat$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=hs@denx$(echo .)de \
--cc=j.neuschaefer@gmx$(echo .)net \
--cc=james.schulman@cirrus$(echo .)com \
--cc=jarkko@kernel$(echo .)org \
--cc=jdelvare@suse$(echo .)com \
--cc=jerome.pouiller@silabs$(echo .)com \
--cc=jgg@ziepe$(echo .)ca \
--cc=jic23@kernel$(echo .)org \
--cc=jingoohan1@gmail$(echo .)com \
--cc=jiri.prchal@aksignal$(echo .)cz \
--cc=jirislaby@kernel$(echo .)org \
--cc=jonathanh@nvidia$(echo .)com \
--cc=kabel@kernel$(echo .)org \
--cc=kamlesh.gurudasani@gmail$(echo .)com \
--cc=kent@minoris$(echo .)se \
--cc=kernel@pengutronix$(echo .)de \
--cc=krzysztof.kozlowski@canonical$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kvalo@kernel$(echo .)org \
--cc=l.stelmach@samsung$(echo .)com \
--cc=lars@metafoo$(echo .)de \
--cc=lee.jones@linaro$(echo .)org \
--cc=lgirdwood@gmail$(echo .)com \
--cc=libertas-dev@lists$(echo .)infradead.org \
--cc=linkmauve@linkmauve$(echo .)fr \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-can@vger$(echo .)kernel.org \
--cc=linux-clk@vger$(echo .)kernel.org \
--cc=linux-fbdev@vger$(echo .)kernel.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-hwmon@vger$(echo .)kernel.org \
--cc=linux-iio@vger$(echo .)kernel.org \
--cc=linux-input@vger$(echo .)kernel.org \
--cc=linux-integrity@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-leds@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mmc@vger$(echo .)kernel.org \
--cc=linux-mtd@lists$(echo .)infradead.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-rtc@vger$(echo .)kernel.org \
--cc=linux-serial@vger$(echo .)kernel.org \
--cc=linux-spi@vger$(echo .)kernel.org \
--cc=linux-staging@lists$(echo .)linux.dev \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linux-wpan@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linux@roeck-us$(echo .)net \
--cc=liuxuenetmail@gmail$(echo .)com \
--cc=m.felsch@pengutronix$(echo .)de \
--cc=mailhol.vincent@wanadoo$(echo .)fr \
--cc=mani@kernel$(echo .)org \
--cc=marcus.folkesson@gmail$(echo .)com \
--cc=mark.tomlinson@alliedtelesis$(echo .)co.nz \
--cc=markgross@kernel$(echo .)org \
--cc=markuss.broks@gmail$(echo .)com \
--cc=matt@bitbashing$(echo .)io \
--cc=mchehab@kernel$(echo .)org \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=mgreer@animalcreek$(echo .)com \
--cc=michael@walle$(echo .)cc \
--cc=mike.looijmans@topic$(echo .)nl \
--cc=miquel.raynal@bootlin$(echo .)com \
--cc=mkl@pengutronix$(echo .)de \
--cc=mripard@kernel$(echo .)org \
--cc=mturquette@baylibre$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=noralf@tronnes$(echo .)org \
--cc=nuno.sa@analog$(echo .)com \
--cc=olteanv@gmail$(echo .)com \
--cc=patches@opensource$(echo .)cirrus.com \
--cc=paulo.miguel.almeida.rodenas@gmail$(echo .)com \
--cc=perex@perex$(echo .)cz \
--cc=peterhuewe@gmx$(echo .)de \
--cc=peterz@infradead$(echo .)org \
--cc=pizza@shaftnet$(echo .)org \
--cc=platform-driver-x86@vger$(echo .)kernel.org \
--cc=rdunlap@infradead$(echo .)org \
--cc=realwakka@gmail$(echo .)com \
--cc=rf@opensource$(echo .)cirrus.com \
--cc=richard@nod$(echo .)at \
--cc=rmfrfs@gmail$(echo .)com \
--cc=ronald@innovation$(echo .)ch \
--cc=sam@ravnborg$(echo .)org \
--cc=sboyd@kernel$(echo .)org \
--cc=shenyang39@huawei$(echo .)com \
--cc=stefan.maetje@esd$(echo .)eu \
--cc=stefan.wahren@i2se$(echo .)com \
--cc=stefan@datenfreihafen$(echo .)org \
--cc=stephan@gerhold$(echo .)net \
--cc=sunnanyong@huawei$(echo .)com \
--cc=support.opensource@diasemi$(echo .)com \
--cc=tanureal@opensource$(echo .)cirrus.com \
--cc=thierry.reding@gmail$(echo .)com \
--cc=thomas.kopp@microchip$(echo .)com \
--cc=tiwai@suse$(echo .)com \
--cc=torin@maxiluxsystems$(echo .)com \
--cc=tudor.ambarus@microchip$(echo .)com \
--cc=tzimmermann@suse$(echo .)de \
--cc=u.kleine-koenig@pengutronix$(echo .)de \
--cc=ulf.hansson@linaro$(echo .)org \
--cc=varkabhadram@gmail$(echo .)com \
--cc=vigneshr@ti$(echo .)com \
--cc=vivien.didelot@gmail$(echo .)com \
--cc=weiyongjun1@huawei$(echo .)com \
--cc=wengjianfeng@yulong$(echo .)com \
--cc=wg@grandegger$(echo .)com \
--cc=will@kernel$(echo .)org \
--cc=woojung.huh@microchip$(echo .)com \
--cc=yang.lee@linux$(echo .)alibaba.com \
--cc=yashsri421@gmail$(echo .)com \
--cc=zhangqilong3@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox