From: Dan Carpenter <dan.carpenter@oracle•com>
To: Duoming Zhou <duoming@zju•edu.cn>
Cc: linux-hams@vger•kernel.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, jreuter@yaina•de, kuba@kernel•org,
davem@davemloft•net, ralf@linux-mips•org, thomas@osterried•de
Subject: Re: [PATCH] ax25: Fix memory leaks caused by ax25_cb_del()
Date: Thu, 10 Mar 2022 16:05:08 +0300 [thread overview]
Message-ID: <20220310130508.GG3315@kadam> (raw)
In-Reply-To: <20220309150608.112090-1-duoming@zju.edu.cn>
This is a very frustrating patch because you make a lot of unnecessary
white space changes and you didn't run checkpatch on your patch.
The whole approach feels like the wrong thing...
I have read your commit message, but I don't understand why we can't
just use normal refcounting. It sounds like there is a layering
violation somewhere?
Even if we go with this approach ->kill_flag and ->bind_flag should be
booleans. It makes no sense to have a unsigned long where only BIT(2)
can be set.
regards,
dan carpenter
next prev parent reply other threads:[~2022-03-10 13:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 15:06 [PATCH] ax25: Fix memory leaks caused by ax25_cb_del() Duoming Zhou
2022-03-10 13:05 ` Dan Carpenter [this message]
2022-03-10 16:01 ` 周多明
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220310130508.GG3315@kadam \
--to=dan.carpenter@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=duoming@zju$(echo .)edu.cn \
--cc=jreuter@yaina$(echo .)de \
--cc=kuba@kernel$(echo .)org \
--cc=linux-hams@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ralf@linux-mips$(echo .)org \
--cc=thomas@osterried$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox