From: Florian Westphal <fw@strlen•de>
To: Randy Dunlap <rdunlap@infradead•org>
Cc: linux-kernel@vger•kernel.org,
"Michael S. Tsirkin" <mst@redhat•com>,
"Jason Wang" <jasowang@redhat•com>,
"Paolo Bonzini" <pbonzini@redhat•com>,
"Stefan Hajnoczi" <stefanha@redhat•com>,
"Jens Axboe" <axboe@kernel•dk>, "Amit Shah" <amit@kernel•org>,
"Arnd Bergmann" <arnd@arndb•de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation•org>,
"Eli Cohen" <eli@mellanox•com>,
"Saeed Mahameed" <saeedm@nvidia•com>,
"Leon Romanovsky" <leon@kernel•org>,
"Pablo Neira Ayuso" <pablo@netfilter•org>,
"Jozsef Kadlecsik" <kadlec@netfilter•org>,
"Florian Westphal" <fw@strlen•de>,
"David S. Miller" <davem@davemloft•net>,
"Jakub Kicinski" <kuba@kernel•org>,
"James E.J. Bottomley" <jejb@linux•ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle•com>,
"Felipe Balbi" <felipe.balbi@linux•intel.com>,
"Michał Mirosław" <mirq-linux@rere•qmqm.pl>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix•de>,
"Krzysztof Opasiak" <k.opasiak@samsung•com>,
"Igor Kotrasinski" <i.kotrasinsk@samsung•com>,
"Valentina Manea" <valentina.manea.m@gmail•com>,
"Shuah Khan" <shuah@kernel•org>,
"Shuah Khan" <skhan@linuxfoundation•org>,
"Jussi Kivilinna" <jussi.kivilinna@mbnet•fi>,
"Joachim Fritschi" <jfritschi@freenet•de>,
"Herbert Xu" <herbert@gondor•apana.org.au>,
"Thomas Gleixner" <tglx@linutronix•de>,
"Steven Rostedt" <rostedt@goodmis•org>,
"Ingo Molnar" <mingo@kernel•org>,
"Karol Herbst" <karolherbst@gmail•com>,
"Pekka Paalanen" <ppaalanen@gmail•com>,
"Dave Hansen" <dave.hansen@linux•intel.com>,
"Andy Lutomirski" <luto@kernel•org>,
"Peter Zijlstra" <peterz@infradead•org>,
"Borislav Petkov" <bp@alien8•de>,
"H. Peter Anvin" <hpa@zytor•com>,
netfilter-devel@vger•kernel.org, coreteam@netfilter•org,
netdev@vger•kernel.org, linux-block@vger•kernel.org,
linux-crypto@vger•kernel.org, linux-rdma@vger•kernel.org,
linux-scsi@vger•kernel.org, linux-usb@vger•kernel.org,
nouveau@lists•freedesktop.org,
virtualization@lists•linux-foundation.org, x86@kernel•org
Subject: Re: [PATCH 4/9] netfilter: h323: eliminate anonymous module_init & module_exit
Date: Thu, 17 Mar 2022 04:42:53 +0100 [thread overview]
Message-ID: <20220317034253.GI9936@breakpoint.cc> (raw)
In-Reply-To: <20220316192010.19001-5-rdunlap@infradead.org>
Randy Dunlap <rdunlap@infradead•org> wrote:
> Eliminate anonymous module_init() and module_exit(), which can lead to
> confusion or ambiguity when reading System.map, crashes/oops/bugs,
> or an initcall_debug log.
>
> Give each of these init and exit functions unique driver-specific
> names to eliminate the anonymous names.
>
> Example 1: (System.map)
> ffffffff832fc78c t init
> ffffffff832fc79e t init
> ffffffff832fc8f8 t init
>
> Example 2: (initcall_debug log)
> calling init+0x0/0x12 @ 1
> initcall init+0x0/0x12 returned 0 after 15 usecs
> calling init+0x0/0x60 @ 1
> initcall init+0x0/0x60 returned 0 after 2 usecs
> calling init+0x0/0x9a @ 1
> initcall init+0x0/0x9a returned 0 after 74 usecs
>
> Fixes: f587de0e2feb ("[NETFILTER]: nf_conntrack/nf_nat: add H.323 helper port")
> Signed-off-by: Randy Dunlap <rdunlap@infradead•org>
Acked-by: Florian Westphal <fw@strlen•de>
next prev parent reply other threads:[~2022-03-17 5:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 19:20 [PATCH 0/9] treewide: eliminate anonymous module_init & module_exit Randy Dunlap
2022-03-16 19:20 ` [PATCH 1/9] virtio_blk: " Randy Dunlap
2022-03-17 3:26 ` Jason Wang
2022-03-17 8:45 ` Stefan Hajnoczi
2022-03-20 12:04 ` Michael S. Tsirkin
2022-03-16 19:20 ` [PATCH 2/9] virtio_console: " Randy Dunlap
2022-03-17 15:47 ` Amit Shah
2022-03-17 20:40 ` Randy Dunlap
2022-03-20 12:04 ` Michael S. Tsirkin
2022-03-16 19:20 ` [PATCH 3/9] net: mlx5: " Randy Dunlap
2022-03-24 18:03 ` Leon Romanovsky
2022-03-16 19:20 ` [PATCH 4/9] netfilter: h323: " Randy Dunlap
2022-03-17 3:42 ` Florian Westphal [this message]
2022-03-17 15:49 ` Pablo Neira Ayuso
2022-03-17 20:42 ` Randy Dunlap
2022-03-19 22:37 ` Pablo Neira Ayuso
2022-03-16 19:20 ` [PATCH 5/9] virtio-scsi: " Randy Dunlap
2022-03-17 3:25 ` Jason Wang
2022-03-17 8:46 ` Stefan Hajnoczi
2022-03-20 12:04 ` Michael S. Tsirkin
2022-03-30 3:51 ` Martin K. Petersen
2022-03-16 19:20 ` [PATCH 6/9] usb: gadget: " Randy Dunlap
2022-03-17 3:29 ` Ira Weiny
2022-03-17 4:59 ` Randy Dunlap
2022-03-16 19:20 ` [PATCH 7/9] usb: usbip: " Randy Dunlap
2022-03-18 22:45 ` Shuah Khan
2022-03-16 19:20 ` [PATCH 8/9] x86/crypto: " Randy Dunlap
2022-04-08 8:31 ` Herbert Xu
2022-03-16 19:20 ` [PATCH 9/9] testmmiotrace: " Randy Dunlap
2022-03-17 2:38 ` Steven Rostedt
2022-03-17 3:32 ` [PATCH 0/9] treewide: " Ira Weiny
2022-03-17 16:11 ` (subset) " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220317034253.GI9936@breakpoint.cc \
--to=fw@strlen$(echo .)de \
--cc=amit@kernel$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=axboe@kernel$(echo .)dk \
--cc=bigeasy@linutronix$(echo .)de \
--cc=bp@alien8$(echo .)de \
--cc=coreteam@netfilter$(echo .)org \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=eli@mellanox$(echo .)com \
--cc=felipe.balbi@linux$(echo .)intel.com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=hpa@zytor$(echo .)com \
--cc=i.kotrasinsk@samsung$(echo .)com \
--cc=jasowang@redhat$(echo .)com \
--cc=jejb@linux$(echo .)ibm.com \
--cc=jfritschi@freenet$(echo .)de \
--cc=jussi.kivilinna@mbnet$(echo .)fi \
--cc=k.opasiak@samsung$(echo .)com \
--cc=kadlec@netfilter$(echo .)org \
--cc=karolherbst@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=linux-block@vger$(echo .)kernel.org \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=luto@kernel$(echo .)org \
--cc=martin.petersen@oracle$(echo .)com \
--cc=mingo@kernel$(echo .)org \
--cc=mirq-linux@rere$(echo .)qmqm.pl \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=nouveau@lists$(echo .)freedesktop.org \
--cc=pablo@netfilter$(echo .)org \
--cc=pbonzini@redhat$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=ppaalanen@gmail$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
--cc=rostedt@goodmis$(echo .)org \
--cc=saeedm@nvidia$(echo .)com \
--cc=shuah@kernel$(echo .)org \
--cc=skhan@linuxfoundation$(echo .)org \
--cc=stefanha@redhat$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=valentina.manea.m@gmail$(echo .)com \
--cc=virtualization@lists$(echo .)linux-foundation.org \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox