From: kernel test robot <lkp@intel•com>
To: Mattias Forsblad <mattias.forsblad@gmail•com>, netdev@vger•kernel.org
Cc: llvm@lists•linux.dev, kbuild-all@lists•01.org,
"David S . Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>, Andrew Lunn <andrew@lunn•ch>,
Florian Fainelli <f.fainelli@gmail•com>,
Vivien Didelot <vivien.didelot@gmail•com>,
Roopa Prabhu <roopa@nvidia•com>,
Tobias Waldekranz <tobias@waldekranz•com>,
Mattias Forsblad <mattias.forsblad+netdev@gmail•com>
Subject: Re: [PATCH v2 net-next 2/5] net: bridge: Implement bridge flood flag
Date: Thu, 17 Mar 2022 04:49:46 +0800 [thread overview]
Message-ID: <202203170401.hynO2BwT-lkp@intel.com> (raw)
In-Reply-To: <20220316153059.2503153-3-mattias.forsblad+netdev@gmail.com>
Hi Mattias,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Mattias-Forsblad/bridge-dsa-switchdev-mv88e6xxx-Implement-bridge-flood-flags/20220316-233416
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 9f01cfbf2922432668c2fd4dfc0413342aaff48b
config: hexagon-randconfig-r045-20220313 (https://download.01.org/0day-ci/archive/20220317/202203170401.hynO2BwT-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project a6ec1e3d798f8eab43fb3a91028c6ab04e115fcb)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4c003fec67078a4e8c1c6e36c7b9fc6303a3bb6f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mattias-Forsblad/bridge-dsa-switchdev-mv88e6xxx-Implement-bridge-flood-flags/20220316-233416
git checkout 4c003fec67078a4e8c1c6e36c7b9fc6303a3bb6f
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash net/bridge/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel•com>
All warnings (new ones prefixed by >>):
net/bridge/br.c:347:26: warning: unused variable 'bm' [-Wunused-variable]
struct br_boolopt_multi bm;
^
>> net/bridge/br.c:361:2: warning: variable 'bropt' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
net/bridge/br.c:365:20: note: uninitialized use occurs here
br_opt_toggle(br, bropt, on);
^~~~~
net/bridge/br.c:348:2: note: variable 'bropt' is declared here
enum net_bridge_opts bropt;
^
2 warnings generated.
vim +/bropt +361 net/bridge/br.c
338
339 int br_flood_toggle(struct net_bridge *br, enum br_boolopt_id opt,
340 bool on)
341 {
342 struct switchdev_attr attr = {
343 .orig_dev = br->dev,
344 .id = SWITCHDEV_ATTR_ID_BRIDGE_FLOOD,
345 .flags = SWITCHDEV_F_DEFER,
346 };
347 struct br_boolopt_multi bm;
348 enum net_bridge_opts bropt;
349 int ret;
350
351 switch (opt) {
352 case BR_BOOLOPT_FLOOD:
353 bropt = BROPT_FLOOD;
354 break;
355 case BR_BOOLOPT_MCAST_FLOOD:
356 bropt = BROPT_MCAST_FLOOD;
357 break;
358 case BR_BOOLOPT_BCAST_FLOOD:
359 bropt = BROPT_BCAST_FLOOD;
360 break;
> 361 default:
362 WARN_ON(1);
363 break;
364 }
365 br_opt_toggle(br, bropt, on);
366
367 attr.u.brport_flags.mask = BIT(bropt);
368 attr.u.brport_flags.val = on << bropt;
369 ret = switchdev_port_attr_set(br->dev, &attr, NULL);
370
371 return ret;
372 }
373
---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next prev parent reply other threads:[~2022-03-16 20:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 15:30 [PATCH v2 net-next 0/5] bridge: dsa: switchdev: mv88e6xxx: Implement bridge flood flags Mattias Forsblad
2022-03-16 15:30 ` [PATCH v2 net-next 1/5] switchdev: Add local_receive attribute Mattias Forsblad
2022-03-16 15:30 ` [PATCH v2 net-next 2/5] net: bridge: Implement bridge flood flag Mattias Forsblad
2022-03-16 20:06 ` Jakub Kicinski
2022-03-16 20:49 ` kernel test robot [this message]
2022-03-16 15:30 ` [PATCH v2 net-next 3/5] dsa: Handle the flood flag in the DSA layer Mattias Forsblad
2022-03-16 15:30 ` [PATCH v2 net-next 4/5] mv88e6xxx: Offload the flood flag Mattias Forsblad
2022-03-16 15:30 ` [PATCH v2 net-next 5/5] selftest: Add bridge flood flag tests Mattias Forsblad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202203170401.hynO2BwT-lkp@intel.com \
--to=lkp@intel$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=kbuild-all@lists$(echo .)01.org \
--cc=kuba@kernel$(echo .)org \
--cc=llvm@lists$(echo .)linux.dev \
--cc=mattias.forsblad+netdev@gmail$(echo .)com \
--cc=mattias.forsblad@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=roopa@nvidia$(echo .)com \
--cc=tobias@waldekranz$(echo .)com \
--cc=vivien.didelot@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox