From: Jakub Kicinski <kuba@kernel•org>
To: andrew@lunn•ch
Cc: Andy Chiu <andy.chiu@sifive•com>,
radhey.shyam.pandey@xilinx•com, robert.hancock@calian•com,
michal.simek@xilinx•com, davem@davemloft•net, pabeni@redhat•com,
robh+dt@kernel•org, linux@armlinux•org.uk,
netdev@vger•kernel.org, devicetree@vger•kernel.org,
robh@kernel•org, Greentime Hu <greentime.hu@sifive•com>
Subject: Re: [PATCH v7 net 4/4] net: axiemac: use a phandle to reference pcs_phy
Date: Tue, 29 Mar 2022 15:56:09 -0700 [thread overview]
Message-ID: <20220329155609.674caa9c@kernel.org> (raw)
In-Reply-To: <20220329024921.2739338-5-andy.chiu@sifive.com>
On Tue, 29 Mar 2022 10:49:21 +0800 Andy Chiu wrote:
> In some SGMII use cases where both a fixed link external PHY and the
> internal PCS/PMA PHY need to be configured, we should explicitly use a
> phandle "pcs-phy" to get the reference to the PCS/PMA PHY. Otherwise, the
> driver would use "phy-handle" in the DT as the reference to both the
> external and the internal PCS/PMA PHY.
>
> In other cases where the core is connected to a SFP cage, we could still
> point phy-handle to the intenal PCS/PMA PHY, and let the driver connect
> to the SFP module, if exist, via phylink.
>
> Fixes: 1a02556086fc (net: axienet: Properly handle PCS/PMA PHY for 1000BaseX mode)
> Signed-off-by: Andy Chiu <andy.chiu@sifive•com>
> Reviewed-by: Greentime Hu <greentime.hu@sifive•com>
> Reviewed-by: Robert Hancock <robert.hancock@calian•com>
I'm not sure if this is a fix or adding support for a new configuration.
Andrew, WDYT?
If it really is a fix and needs to be backported we should take patch 2
out of this series, and post it separately later. Refactoring does not
belong in stable trees.
next prev parent reply other threads:[~2022-03-29 22:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 2:49 [PATCH v7 net 0/4] Fix broken link on Xilinx's AXI Ethernet in SGMII mode Andy Chiu
2022-03-29 2:49 ` [PATCH v7 net 1/4] net: axienet: setup mdio unconditionally Andy Chiu
2022-03-29 2:49 ` [PATCH v7 net 2/4] net: axienet: factor out phy_node in struct axienet_local Andy Chiu
2022-03-29 2:49 ` [PATCH v7 net 3/4] dt-bindings: net: add pcs-handle attribute Andy Chiu
2022-04-04 18:08 ` Rob Herring
2022-03-29 2:49 ` [PATCH v7 net 4/4] net: axiemac: use a phandle to reference pcs_phy Andy Chiu
2022-03-29 22:56 ` Jakub Kicinski [this message]
2022-03-30 1:25 ` Andrew Lunn
2022-03-30 1:48 ` Jakub Kicinski
2022-03-30 8:50 ` Andy Chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220329155609.674caa9c@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=andy.chiu@sifive$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=greentime.hu@sifive$(echo .)com \
--cc=linux@armlinux$(echo .)org.uk \
--cc=michal.simek@xilinx$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=radhey.shyam.pandey@xilinx$(echo .)com \
--cc=robert.hancock@calian$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=robh@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox