From: Jakub Kicinski <kuba@kernel•org>
To: jmaloy@redhat•com
Cc: netdev@vger•kernel.org, davem@davemloft•net,
tipc-discussion@lists•sourceforge.net,
tung.q.nguyen@dektech•com.au, hoang.h.le@dektech•com.au,
tuong.t.lien@dektech•com.au, maloy@donjonn•com, xinl@redhat•com,
ying.xue@windriver•com, parthasarathy.bhuvaragan@gmail•com
Subject: Re: [net-next] tipc: clarify meaning of 'inactive' field in struct tipc_subscription
Date: Tue, 29 Mar 2022 18:22:45 -0700 [thread overview]
Message-ID: <20220329182245.0127ccbc@kernel.org> (raw)
In-Reply-To: <20220329173218.1737499-1-jmaloy@redhat.com>
On Tue, 29 Mar 2022 13:32:18 -0400 jmaloy@redhat•com wrote:
> From: Jon Maloy <jmaloy@redhat•com>
>
> struct tipc_subscription has a boolean field 'inactive' which purpose
> is not immediately obvious. When the subscription timer expires we are
> still in interrupt context, and cannot easily just delete the
> subscription. We therefore delay that action until the expiration
> event has reached the work queue context where it is being sent to the
> user. However, in the meantime other events may occur, which must be
> suppressed to avoid any unexpected behavior.
>
> We now clarify this with renaming the field and adding a comment.
>
> Signed-off-by: Jon Maloy <jmaloy@redhat•com>
# Form letter - net-next is closed
We have already sent the networking pull request for 5.18
and therefore net-next is closed for new drivers, features,
code refactoring and optimizations. We are currently accepting
bug fixes only.
Please repost when net-next reopens after 5.18-rc1 is cut.
RFC patches sent for review only are obviously welcome at any time.
prev parent reply other threads:[~2022-03-30 1:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 17:32 [net-next] tipc: clarify meaning of 'inactive' field in struct tipc_subscription jmaloy
2022-03-30 1:22 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220329182245.0127ccbc@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=hoang.h.le@dektech$(echo .)com.au \
--cc=jmaloy@redhat$(echo .)com \
--cc=maloy@donjonn$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=parthasarathy.bhuvaragan@gmail$(echo .)com \
--cc=tipc-discussion@lists$(echo .)sourceforge.net \
--cc=tung.q.nguyen@dektech$(echo .)com.au \
--cc=tuong.t.lien@dektech$(echo .)com.au \
--cc=xinl@redhat$(echo .)com \
--cc=ying.xue@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox