Subject: Re: [PATCH] qed: remove an unneed NULL check on list iterator

From: Jakub Kicinski <[email-masked]>
Date: Tue, 5 Apr 2022 18:26:41 -0700

On Tue,  5 Apr 2022 08:22:56 +0800 Xiaomeng Tong wrote:
>  struct pci_dev *qed_validate_ndev(struct net_device *ndev)
>  {
> -	struct pci_dev *pdev = NULL;
> +	struct pci_dev *pdev;
>  	struct net_device *upper;

Please keep the longest-to-shortest ordering of variable declaration
lines.