From: Jakub Kicinski <kuba@kernel•org>
To: Luis Chamberlain <mcgrof@kernel•org>
Cc: xiangxia.m.yue@gmail•com, netdev@vger•kernel.org,
Kees Cook <keescook@chromium•org>,
Iurii Zaikin <yzaikin@google•com>,
"David S. Miller" <davem@davemloft•net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6•org>,
David Ahern <dsahern@kernel•org>,
Simon Horman <horms@verge•net.au>, Julian Anastasov <ja@ssi•bg>,
Pablo Neira Ayuso <pablo@netfilter•org>,
Jozsef Kadlecsik <kadlec@netfilter•org>,
Florian Westphal <fw@strlen•de>,
Dmitry Vyukov <dvyukov@google•com>,
Alexei Starovoitov <ast@kernel•org>,
Eric Dumazet <edumazet@google•com>,
Marc Kleine-Budde <mkl@pengutronix•de>,
Lorenz Bauer <lmb@cloudflare•com>,
Akhmat Karakotov <hmukos@yandex-team•ru>
Subject: Re: [net-next RESEND v2] net: core: use shared sysctl macro
Date: Wed, 6 Apr 2022 12:16:11 -0700 [thread overview]
Message-ID: <20220406121611.1791499d@kernel.org> (raw)
In-Reply-To: <Yk29yO53lSigIbml@bombadil.infradead.org>
On Wed, 6 Apr 2022 09:20:24 -0700 Luis Chamberlain wrote:
> On Wed, Apr 06, 2022 at 08:42:08PM +0800, xiangxia.m.yue@gmail•com wrote:
> > From: Tonghao Zhang <xiangxia.m.yue@gmail•com>
> >
> > This patch introdues the SYSCTL_THREE, and replace the
> > two, three and long_one to SYSCTL_XXX accordingly.
> >
> > KUnit:
> > [23:03:58] ================ sysctl_test (10 subtests) =================
> > [23:03:58] [PASSED] sysctl_test_api_dointvec_null_tbl_data
> > [23:03:58] [PASSED] sysctl_test_api_dointvec_table_maxlen_unset
> > [23:03:58] [PASSED] sysctl_test_api_dointvec_table_len_is_zero
> > [23:03:58] [PASSED] sysctl_test_api_dointvec_table_read_but_position_set
> > [23:03:58] [PASSED] sysctl_test_dointvec_read_happy_single_positive
> > [23:03:58] [PASSED] sysctl_test_dointvec_read_happy_single_negative
> > [23:03:58] [PASSED] sysctl_test_dointvec_write_happy_single_positive
> > [23:03:58] [PASSED] sysctl_test_dointvec_write_happy_single_negative
> > [23:03:58] [PASSED] sysctl_test_api_dointvec_write_single_less_int_min
> > [23:03:58] [PASSED] sysctl_test_api_dointvec_write_single_greater_int_max
> > [23:03:58] =================== [PASSED] sysctl_test ===================
> >
> > ./run_kselftest.sh -c sysctl
> > ...
> > # Running test: sysctl_test_0006 - run #49
> > # Checking bitmap handler... ok
> > # Wed Mar 16 14:58:41 UTC 2022
> > # Running test: sysctl_test_0007 - run #0
> > # Boot param test only possible sysctl_test is built-in, not module:
> > # CONFIG_TEST_SYSCTL=m
> > ok 1 selftests: sysctl: sysctl.sh
>
> I can take this through sysctl-next [0] if folks are OK with that. There are
> quite a bit of changes already queued there for sysctl.
>
> Jakub?
>
> [0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=sysctl-next
sysctl-next makes a lot of sense, but I'm worried about conflicts.
Would you be able to spin up a stable branch based on -rc1 so we
can pull it into net-next as well?
Let me take a look at the patch as well...
next prev parent reply other threads:[~2022-04-06 20:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 12:42 [net-next RESEND v2] net: core: use shared sysctl macro xiangxia.m.yue
2022-04-06 16:20 ` Luis Chamberlain
2022-04-06 19:16 ` Jakub Kicinski [this message]
2022-04-06 20:46 ` Luis Chamberlain
2022-04-06 21:06 ` Jakub Kicinski
2022-04-06 21:17 ` Luis Chamberlain
2022-04-06 19:25 ` Jakub Kicinski
2022-04-07 12:50 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220406121611.1791499d@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=dvyukov@google$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=fw@strlen$(echo .)de \
--cc=hmukos@yandex-team$(echo .)ru \
--cc=horms@verge$(echo .)net.au \
--cc=ja@ssi$(echo .)bg \
--cc=kadlec@netfilter$(echo .)org \
--cc=keescook@chromium$(echo .)org \
--cc=lmb@cloudflare$(echo .)com \
--cc=mcgrof@kernel$(echo .)org \
--cc=mkl@pengutronix$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pablo@netfilter$(echo .)org \
--cc=xiangxia.m.yue@gmail$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
--cc=yzaikin@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox