From: Jakub Kicinski <kuba@kernel•org>
To: Oliver Hartkopp <socketcan@hartkopp•net>
Cc: netdev@vger•kernel.org, davem@davemloft•net,
kernel test robot <lkp@intel•com>
Subject: Re: [PATCH RESEND net-next v4] net: remove noblock parameter from skb_recv_datagram()
Date: Wed, 6 Apr 2022 22:07:45 -0700 [thread overview]
Message-ID: <20220406220745.2fe27055@kernel.org> (raw)
In-Reply-To: <20220404163022.88751-1-socketcan@hartkopp.net>
On Mon, 4 Apr 2022 18:30:22 +0200 Oliver Hartkopp wrote:
> skb_recv_datagram() has two parameters 'flags' and 'noblock' that are
> merged inside skb_recv_datagram() by 'flags | (noblock ? MSG_DONTWAIT : 0)'
>
> As 'flags' may contain MSG_DONTWAIT as value most callers split the 'flags'
> into 'flags' and 'noblock' with finally obsolete bit operations like this:
>
> skb_recv_datagram(sk, flags & ~MSG_DONTWAIT, flags & MSG_DONTWAIT, &rc);
>
> And this is not even done consistently with the 'flags' parameter.
>
> This patch removes the obsolete and costly splitting into two parameters
> and only performs bit operations when really needed on the caller side.
>
> One missing conversion thankfully reported by kernel test robot. I missed
> to enable kunit tests to build the mctp code.
>
> Reported-by: kernel test robot <lkp@intel•com>
> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp•net>
We may have missed the pw bot's reply. Either that or vger ate it for
me. Looks like this is commit f4b41f062c42 ("net: remove noblock
parameter from skb_recv_datagram()") in net-next. Thanks!
next prev parent reply other threads:[~2022-04-07 5:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 16:30 [PATCH RESEND net-next v4] net: remove noblock parameter from skb_recv_datagram() Oliver Hartkopp
2022-04-07 5:07 ` Jakub Kicinski [this message]
2022-04-07 6:30 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220406220745.2fe27055@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=lkp@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=socketcan@hartkopp$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox