From: Jason Gunthorpe <jgg@nvidia•com>
To: "Tian, Kevin" <kevin.tian@intel•com>
Cc: Alex Williamson <alex.williamson@redhat•com>,
Lu Baolu <baolu.lu@linux•intel.com>,
Christian Benvenuti <benve@cisco•com>,
Cornelia Huck <cohuck@redhat•com>,
David Woodhouse <dwmw2@infradead•org>,
Gerald Schaefer <gerald.schaefer@linux•ibm.com>,
"iommu@lists•linux-foundation.org"
<iommu@lists•linux-foundation.org>,
Jason Wang <jasowang@redhat•com>, Joerg Roedel <joro@8bytes•org>,
"kvm@vger•kernel.org" <kvm@vger•kernel.org>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
"linux-arm-msm@vger•kernel.org" <linux-arm-msm@vger•kernel.org>,
"linux-rdma@vger•kernel.org" <linux-rdma@vger•kernel.org>,
"linux-s390@vger•kernel.org" <linux-s390@vger•kernel.org>,
Matthew Rosato <mjrosato@linux•ibm.com>,
"Michael S. Tsirkin" <mst@redhat•com>,
Nelson Escobar <neescoba@cisco•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
Rob Clark <robdclark@gmail•com>,
Robin Murphy <robin.murphy@arm•com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd•com>,
"virtualization@lists•linux-foundation.org"
<virtualization@lists•linux-foundation.org>,
Will Deacon <will@kernel•org>, Christoph Hellwig <hch@lst•de>
Subject: Re: [PATCH 2/5] vfio: Require that devices support DMA cache coherence
Date: Thu, 7 Apr 2022 11:53:32 -0300 [thread overview]
Message-ID: <20220407145332.GA3397825@nvidia.com> (raw)
In-Reply-To: <BN9PR11MB52766319F89353256863D41E8CE79@BN9PR11MB5276.namprd11.prod.outlook.com>
On Wed, Apr 06, 2022 at 07:02:36AM +0000, Tian, Kevin wrote:
> > So like this:
> >
> > int vfio_register_group_dev(struct vfio_device *device)
> > {
> > + if (!dev_is_dma_coherent(device->dev))
> > + return -EINVAL;
> > +
> > return __vfio_register_dev(device,
> > vfio_group_find_or_alloc(device->dev));
> > }
> >
> > I fixed it up.
> >
>
> if that is the case should it also apply to usnic and vdpa in the first
> patch (i.e. fail the probe)?
Ideally, but I don't want to mess with existing logic in these
drivers..
Thanks,
Jason
next prev parent reply other threads:[~2022-04-07 14:53 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 16:15 [PATCH 0/5] Make the iommu driver no-snoop block feature consistent Jason Gunthorpe
2022-04-05 16:16 ` [PATCH 1/5] iommu: Replace uses of IOMMU_CAP_CACHE_COHERENCY with dev_is_dma_coherent() Jason Gunthorpe
2022-04-06 5:30 ` Christoph Hellwig
2022-04-06 12:07 ` Jason Gunthorpe
2022-04-06 13:51 ` Christoph Hellwig
2022-04-06 14:14 ` Jason Gunthorpe
2022-04-06 15:47 ` Christoph Hellwig
2022-04-06 15:48 ` Jason Gunthorpe
2022-04-06 15:48 ` Robin Murphy
2022-04-06 13:56 ` Robin Murphy
2022-04-06 14:24 ` Jason Gunthorpe
2022-04-06 15:18 ` Jason Gunthorpe
2022-04-06 15:50 ` Christoph Hellwig
2022-04-06 16:06 ` Jason Gunthorpe
2022-04-06 16:10 ` Christoph Hellwig
2022-04-06 17:17 ` Jason Gunthorpe
2022-04-07 7:18 ` Tian, Kevin
2022-04-07 13:59 ` Jason Gunthorpe
2022-04-07 15:17 ` Robin Murphy
2022-04-07 15:23 ` Jason Gunthorpe
2022-04-07 22:37 ` Alex Williamson
2022-04-07 15:31 ` Christoph Hellwig
2022-04-07 8:53 ` Niklas Schnelle
2022-04-05 16:16 ` [PATCH 2/5] vfio: Require that devices support DMA cache coherence Jason Gunthorpe
2022-04-05 19:10 ` Alex Williamson
2022-04-05 19:29 ` Jason Gunthorpe
2022-04-06 7:02 ` Tian, Kevin
2022-04-07 14:53 ` Jason Gunthorpe [this message]
2022-04-05 16:16 ` [PATCH 3/5] iommu: Introduce the domain op enforce_cache_coherency() Jason Gunthorpe
2022-04-05 19:50 ` Alex Williamson
2022-04-05 22:57 ` Jason Gunthorpe
2022-04-05 23:31 ` Tian, Kevin
2022-04-06 0:08 ` Tian, Kevin
2022-04-06 7:09 ` Tian, Kevin
2022-04-06 12:27 ` Jason Gunthorpe
2022-04-05 16:16 ` [PATCH 4/5] vfio: Move the Intel no-snoop control off of IOMMU_CACHE Jason Gunthorpe
2022-04-05 16:16 ` [PATCH 5/5] iommu: Delete IOMMU_CAP_CACHE_COHERENCY Jason Gunthorpe
2022-04-06 6:52 ` [PATCH 0/5] Make the iommu driver no-snoop block feature consistent Tian, Kevin
2022-04-07 14:56 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220407145332.GA3397825@nvidia.com \
--to=jgg@nvidia$(echo .)com \
--cc=alex.williamson@redhat$(echo .)com \
--cc=baolu.lu@linux$(echo .)intel.com \
--cc=benve@cisco$(echo .)com \
--cc=cohuck@redhat$(echo .)com \
--cc=dwmw2@infradead$(echo .)org \
--cc=gerald.schaefer@linux$(echo .)ibm.com \
--cc=hch@lst$(echo .)de \
--cc=iommu@lists$(echo .)linux-foundation.org \
--cc=jasowang@redhat$(echo .)com \
--cc=joro@8bytes$(echo .)org \
--cc=kevin.tian@intel$(echo .)com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=mjrosato@linux$(echo .)ibm.com \
--cc=mst@redhat$(echo .)com \
--cc=neescoba@cisco$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=robdclark@gmail$(echo .)com \
--cc=robin.murphy@arm$(echo .)com \
--cc=suravee.suthikulpanit@amd$(echo .)com \
--cc=virtualization@lists$(echo .)linux-foundation.org \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox