From: Jakub Kicinski <kuba@kernel•org>
To: Jakob Koschel <jakobkoschel@gmail•com>
Cc: "David S. Miller" <davem@davemloft•net>,
Paolo Abeni <pabeni@redhat•com>, Andrew Lunn <andrew@lunn•ch>,
Vivien Didelot <vivien.didelot@gmail•com>,
Florian Fainelli <f.fainelli@gmail•com>,
Vladimir Oltean <olteanv@gmail•com>,
Lars Povlsen <lars.povlsen@microchip•com>,
Steen Hegelund <Steen.Hegelund@microchip•com>,
UNGLinuxDriver@microchip•com, Ariel Elior <aelior@marvell•com>,
Manish Chopra <manishc@marvell•com>,
Edward Cree <ecree.xilinx@gmail•com>,
Martin Habets <habetsm.xilinx@gmail•com>,
Michael Ellerman <mpe@ellerman•id.au>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>, Jiri Pirko <jiri@resnulli•us>,
Casper Andersson <casper.casan@gmail•com>,
Bjarni Jonasson <bjarni.jonasson@microchip•com>,
Colin Ian King <colin.king@intel•com>,
Michael Walle <michael@walle•cc>,
Christophe JAILLET <christophe.jaillet@wanadoo•fr>,
Arnd Bergmann <arnd@arndb•de>, Eric Dumazet <edumazet@google•com>,
Di Zhu <zhudi21@huawei•com>, Xu Wang <vulab@iscas•ac.cn>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linuxppc-dev@lists•ozlabs.org, Mike Rapoport <rppt@kernel•org>,
Brian Johannesmeyer <bjohannesmeyer@gmail•com>,
Cristiano Giuffrida <c.giuffrida@vu•nl>,
"Bos, H.J." <h.j.bos@vu•nl>
Subject: Re: [PATCH net-next 02/15] net: dsa: sja1105: Remove usage of iterator for list_add() after loop
Date: Fri, 8 Apr 2022 17:04:23 -0700 [thread overview]
Message-ID: <20220408170423.35b379d9@kernel.org> (raw)
In-Reply-To: <AAB64C72-5B45-4BA1-BB48-106F08BDFF1B@gmail.com>
On Sat, 9 Apr 2022 01:58:29 +0200 Jakob Koschel wrote:
> > This turns a pretty slick piece of code into something ugly :(
> > I'd rather you open coded the iteration here than make it more
> > complex to satisfy "safe coding guidelines".
>
> I'm not entirely sure I understand what you mean with
> "open coded the iteration". But maybe the solution proposed by Vladimir [1]
> works for you?
Yup, that's what I meant!
> I'm planning to rewrite the cases in that way for the relevant ones.
>
> > Also the list_add() could be converted to list_add_tail().
>
> Good point, I wasn't sure if that's considered as something that should be
> done as a separate change. I'm happy to include it in v2.
Ack, separate patch would be better for that. I guess Vladimir may have
used .prev on purpose, since _tail() doesn't intuitively scream _after()
Anyway, not important.
next prev parent reply other threads:[~2022-04-09 0:04 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 10:28 [PATCH net-next 00/15] net: Remove use of list iterator after loop body Jakob Koschel
2022-04-07 10:28 ` [PATCH net-next 01/15] connector: Replace usage of found with dedicated list iterator variable Jakob Koschel
2022-04-07 10:28 ` [PATCH net-next 02/15] net: dsa: sja1105: Remove usage of iterator for list_add() after loop Jakob Koschel
2022-04-08 3:54 ` Jakub Kicinski
2022-04-08 23:58 ` Jakob Koschel
2022-04-09 0:04 ` Jakub Kicinski [this message]
2022-04-09 0:08 ` Vladimir Oltean
2022-04-08 7:47 ` Christophe Leroy
2022-04-08 23:49 ` Jakob Koschel
2022-04-08 11:41 ` Vladimir Oltean
2022-04-08 23:54 ` Jakob Koschel
2022-04-10 10:51 ` Jakob Koschel
2022-04-10 11:05 ` Vladimir Oltean
2022-04-10 12:39 ` Jakob Koschel
2022-04-10 18:24 ` Jakob Koschel
2022-04-10 20:02 ` Vladimir Oltean
2022-04-10 20:30 ` Jakob Koschel
2022-04-10 20:34 ` Vladimir Oltean
2022-04-07 10:28 ` [PATCH net-next 03/15] net: dsa: mv88e6xxx: Replace usage of found with dedicated iterator Jakob Koschel
2022-04-08 12:31 ` Vladimir Oltean
2022-04-08 23:44 ` Jakob Koschel
2022-04-08 23:50 ` Vladimir Oltean
2022-04-09 0:00 ` Jakob Koschel
2022-04-07 10:28 ` [PATCH net-next 04/15] net: dsa: Replace usage of found with dedicated list iterator variable Jakob Koschel
2022-04-07 10:28 ` [PATCH net-next 05/15] net: sparx5: " Jakob Koschel
2022-04-07 10:28 ` [PATCH net-next 06/15] qed: Use " Jakob Koschel
2022-04-07 10:28 ` [PATCH net-next 07/15] qed: Replace usage of found with " Jakob Koschel
2022-04-07 10:28 ` [PATCH net-next 08/15] qed: Remove usage of list iterator variable after the loop Jakob Koschel
2022-04-07 10:28 ` [PATCH net-next 09/15] net: qede: Replace usage of found with dedicated list iterator variable Jakob Koschel
2022-04-07 10:28 ` [PATCH net-next 10/15] net: qede: Remove check of list iterator against head past the loop body Jakob Koschel
2022-04-07 10:28 ` [PATCH net-next 11/15] sfc: Remove usage of list iterator for list_add() after " Jakob Koschel
2022-04-07 17:42 ` Edward Cree
2022-04-09 0:10 ` Jakob Koschel
2022-04-07 10:28 ` [PATCH net-next 12/15] net: netcp: Remove usage of list iterator for list_add() after " Jakob Koschel
2022-04-07 10:28 ` [PATCH net-next 13/15] ps3_gelic: Replace usage of found with dedicated list iterator variable Jakob Koschel
2022-04-07 10:28 ` [PATCH net-next 14/15] ipvlan: Remove usage of list iterator variable for the loop body Jakob Koschel
2022-04-07 10:29 ` [PATCH net-next 15/15] team: Remove use of list iterator variable for list_for_each_entry_from() Jakob Koschel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220408170423.35b379d9@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=Steen.Hegelund@microchip$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=aelior@marvell$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=arnd@arndb$(echo .)de \
--cc=benh@kernel$(echo .)crashing.org \
--cc=bjarni.jonasson@microchip$(echo .)com \
--cc=bjohannesmeyer@gmail$(echo .)com \
--cc=c.giuffrida@vu$(echo .)nl \
--cc=casper.casan@gmail$(echo .)com \
--cc=christophe.jaillet@wanadoo$(echo .)fr \
--cc=colin.king@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ecree.xilinx@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=h.j.bos@vu$(echo .)nl \
--cc=habetsm.xilinx@gmail$(echo .)com \
--cc=jakobkoschel@gmail$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=lars.povlsen@microchip$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=manishc@marvell$(echo .)com \
--cc=michael@walle$(echo .)cc \
--cc=mpe@ellerman$(echo .)id.au \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=rppt@kernel$(echo .)org \
--cc=vivien.didelot@gmail$(echo .)com \
--cc=vulab@iscas$(echo .)ac.cn \
--cc=zhudi21@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox