Subject: Re: [PATCH net-next 0/5] flower: match on the number of vlan tags

From: Boris Sukholitko <[email-masked]>
Date: Thu, 14 Apr 2022 15:59:40 +0300

On Tue, Apr 12, 2022 at 06:54:43AM -0400, Jamal Hadi Salim wrote:
> On 2022-04-11 10:56, Boris Sukholitko wrote:
> > On Mon, Apr 11, 2022 at 10:07:14AM -0400, Jamal Hadi Salim wrote:
> > > On 2022-04-11 09:30, Boris Sukholitko wrote:
> > > > Hi,
> 
> [..]
> 
> > > Can you please provide more elaborate example of more than 1 vlan?
> > 
> > Perusing our logs, we have redirect rules such as:
> > 
> > tc filter add dev $GPON ingress flower num_of_vlans $N \
> >     action mirred egress redirect dev $DEV
> > 
> 
> Please add in the commit logs.
> 
> > where N can range from 0 to 3 and $DEV is the function of $N.
> > 
> 
> Also in the commit log, very specific to GPON. I have seen upto
> 4 in some telco environment.
> 
> > Also there are rules setting skb mark based on the number of vlans:
> > 
> > tc filter add dev $GPON ingress flower num_of_vlans $N vlan_prio \
> >     $P action skbedit mark $M
> > 

All of the above added to the commit log in v3 (added to the cover and
patch 3 in the series).

> 
> Yep makes sense.
> 
> 
> > > Where would the line be drawn:
> > > Is it max of two vlans?
> > 
> > We have seen the maximum of 3 vlans.
> > 
> > > Is there potential of <=X, meaning matching of upto X Vlans?
> > > 
> > 
> > We've managed to get by without such feature somehow :)
> 
> If needed should be extensible. You already have ability to count, so
> adding inequality check should not be hard to add when needed.
> 

Yes, it can certainly be done as a further patch.

Thanks,
Boris.