From: Andrea Parri <parri.andrea@gmail•com>
To: "Michael Kelley (LINUX)" <mikelley@microsoft•com>
Cc: KY Srinivasan <kys@microsoft•com>,
Haiyang Zhang <haiyangz@microsoft•com>,
Stephen Hemminger <sthemmin@microsoft•com>,
Wei Liu <wei.liu@kernel•org>, Dexuan Cui <decui@microsoft•com>,
Stefano Garzarella <sgarzare@redhat•com>,
David Miller <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
"linux-hyperv@vger•kernel.org" <linux-hyperv@vger•kernel.org>,
"virtualization@lists•linux-foundation.org"
<virtualization@lists•linux-foundation.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>
Subject: Re: [RFC PATCH 6/6] Drivers: hv: vmbus: Refactor the ring-buffer iterator functions
Date: Fri, 15 Apr 2022 09:00:31 +0200 [thread overview]
Message-ID: <20220415070031.GE2961@anparri> (raw)
In-Reply-To: <PH0PR21MB302516C5334076716966B7EED7EE9@PH0PR21MB3025.namprd21.prod.outlook.com>
> > @@ -470,7 +471,6 @@ struct vmpacket_descriptor *hv_pkt_iter_first_raw(struct
> > vmbus_channel *channel)
> >
> > return (struct vmpacket_descriptor *)(hv_get_ring_buffer(rbi) + rbi-
> > >priv_read_index);
> > }
> > -EXPORT_SYMBOL_GPL(hv_pkt_iter_first_raw);
>
> Does hv_pkt_iter_first_raw() need to be retained at all as a
> separate function? I think after these changes, the only caller
> is hv_pkt_iter_first(), in which case the code could just go
> inline in hv_pkt_iter_first(). Doing that combining would
> also allow the elimination of the duplicate call to
> hv_pkt_iter_avail().
Good point. Will do.
Thanks,
Andrea
next prev parent reply other threads:[~2022-04-15 7:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 20:47 [RFC PATCH 0/6] hv_sock: Hardening changes Andrea Parri (Microsoft)
2022-04-13 20:47 ` [RFC PATCH 1/6] hv_sock: Check hv_pkt_iter_first_raw()'s return value Andrea Parri (Microsoft)
2022-04-15 3:33 ` Michael Kelley (LINUX)
2022-04-15 6:41 ` Andrea Parri
2022-04-15 14:27 ` Michael Kelley (LINUX)
2022-04-15 16:09 ` Andrea Parri
2022-04-13 20:47 ` [RFC PATCH 2/6] hv_sock: Copy packets sent by Hyper-V out of the ring buffer Andrea Parri (Microsoft)
2022-04-15 3:33 ` Michael Kelley (LINUX)
2022-04-15 6:42 ` Andrea Parri
2022-04-13 20:47 ` [RFC PATCH 3/6] hv_sock: Add validation for untrusted Hyper-V values Andrea Parri (Microsoft)
2022-04-13 20:47 ` [RFC PATCH 4/6] hv_sock: Initialize send_buf in hvs_stream_enqueue() Andrea Parri (Microsoft)
2022-04-15 3:33 ` Michael Kelley (LINUX)
2022-04-15 6:50 ` Andrea Parri
2022-04-15 14:30 ` Michael Kelley (LINUX)
2022-04-15 16:16 ` Andrea Parri
2022-04-13 20:47 ` [RFC PATCH 5/6] Drivers: hv: vmbus: Accept hv_sock offers in isolated guests Andrea Parri (Microsoft)
2022-04-15 3:33 ` Michael Kelley (LINUX)
2022-04-15 6:58 ` Andrea Parri
2022-04-13 20:47 ` [RFC PATCH 6/6] Drivers: hv: vmbus: Refactor the ring-buffer iterator functions Andrea Parri (Microsoft)
2022-04-15 3:34 ` Michael Kelley (LINUX)
2022-04-15 7:00 ` Andrea Parri [this message]
2022-04-15 16:28 ` Andrea Parri
2022-04-15 16:44 ` Michael Kelley (LINUX)
2022-04-15 17:05 ` Andrea Parri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220415070031.GE2961@anparri \
--to=parri.andrea@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=decui@microsoft$(echo .)com \
--cc=haiyangz@microsoft$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kys@microsoft$(echo .)com \
--cc=linux-hyperv@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mikelley@microsoft$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sgarzare@redhat$(echo .)com \
--cc=sthemmin@microsoft$(echo .)com \
--cc=virtualization@lists$(echo .)linux-foundation.org \
--cc=wei.liu@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox