From: Jakub Kicinski <kuba@kernel•org>
To: Luis Chamberlain <mcgrof@kernel•org>
Cc: xiangxia.m.yue@gmail•com, netdev@vger•kernel.org,
linux-fsdevel@vger•kernel.org, Kees Cook <keescook@chromium•org>,
Iurii Zaikin <yzaikin@google•com>,
"David S. Miller" <davem@davemloft•net>,
Paolo Abeni <pabeni@redhat•com>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6•org>,
David Ahern <dsahern@kernel•org>,
Simon Horman <horms@verge•net.au>, Julian Anastasov <ja@ssi•bg>,
Pablo Neira Ayuso <pablo@netfilter•org>,
Jozsef Kadlecsik <kadlec@netfilter•org>,
Florian Westphal <fw@strlen•de>, Shuah Khan <shuah@kernel•org>,
Andrew Morton <akpm@linux-foundation•org>,
Alexei Starovoitov <ast@kernel•org>,
Eric Dumazet <edumazet@google•com>,
Lorenz Bauer <lmb@cloudflare•com>,
Akhmat Karakotov <hmukos@yandex-team•ru>
Subject: Re: [net-next v4 0/3] use standard sysctl macro
Date: Fri, 22 Apr 2022 12:43:40 -0700 [thread overview]
Message-ID: <20220422124340.2382da79@kernel.org> (raw)
In-Reply-To: <YmK/PM2x5PTG2b+c@bombadil.infradead.org>
On Fri, 22 Apr 2022 07:44:12 -0700 Luis Chamberlain wrote:
> On Fri, Apr 22, 2022 at 03:01:38PM +0800, xiangxia.m.yue@gmail•com wrote:
> > From: Tonghao Zhang <xiangxia.m.yue@gmail•com>
> >
> > This patchset introduce sysctl macro or replace var
> > with macro.
> >
> > Tonghao Zhang (3):
> > net: sysctl: use shared sysctl macro
> > net: sysctl: introduce sysctl SYSCTL_THREE
> > selftests/sysctl: add sysctl macro test
>
> I see these are based on net-next, to avoid conflicts with
> sysctl development this may be best based on sysctl-next
> though. Jakub?
I guess the base should be whatever we are going to use as
a base for a branch, the branch we can both pull in?
How many patches like that do you see flying around, tho?
I feel like I've seen at least 3 - netfilter, net core and bpf.
It's starting to feel like we should have one patch that adds all
the constants and self test, put that in a branch anyone can pull in,
and then do the conversions in separate patches..
Option number two - rename the statics in the subsystems to SYSCTL_x,
and we can do a much smaller cleanup in the next cycle which would
replace those with a centralized instances? That should have minimal
chance of conflicts so no need to do special branches.
Option number three defer all this until the merge window.
next prev parent reply other threads:[~2022-04-22 21:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 7:01 [net-next v4 0/3] use standard sysctl macro xiangxia.m.yue
2022-04-22 7:01 ` [net-next v4 1/3] net: sysctl: use shared " xiangxia.m.yue
2022-04-22 7:01 ` [net-next v4 2/3] net: sysctl: introduce sysctl SYSCTL_THREE xiangxia.m.yue
2022-04-22 7:01 ` [net-next v4 3/3] selftests/sysctl: add sysctl macro test xiangxia.m.yue
2022-04-25 19:58 ` Jakub Kicinski
2022-05-01 3:31 ` Tonghao Zhang
2022-05-02 14:26 ` Jakub Kicinski
2022-04-22 14:44 ` [net-next v4 0/3] use standard sysctl macro Luis Chamberlain
2022-04-22 19:43 ` Jakub Kicinski [this message]
2022-04-25 19:47 ` Luis Chamberlain
2022-04-25 19:56 ` Jakub Kicinski
2022-04-25 20:53 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220422124340.2382da79@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=fw@strlen$(echo .)de \
--cc=hmukos@yandex-team$(echo .)ru \
--cc=horms@verge$(echo .)net.au \
--cc=ja@ssi$(echo .)bg \
--cc=kadlec@netfilter$(echo .)org \
--cc=keescook@chromium$(echo .)org \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=lmb@cloudflare$(echo .)com \
--cc=mcgrof@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pablo@netfilter$(echo .)org \
--cc=shuah@kernel$(echo .)org \
--cc=xiangxia.m.yue@gmail$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
--cc=yzaikin@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox