From: Jakub Kicinski <kuba@kernel•org>
To: Vladimir Oltean <vladimir.oltean@nxp•com>
Cc: "davem@davemloft•net" <davem@davemloft•net>,
"pabeni@redhat•com" <pabeni@redhat•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"grygorii.strashko@ti•com" <grygorii.strashko@ti•com>,
"chi.minghao@zte•com.cn" <chi.minghao@zte•com.cn>,
"toke@redhat•com" <toke@redhat•com>,
"chenhao288@hisilicon•com" <chenhao288@hisilicon•com>,
"moyufeng@huawei•com" <moyufeng@huawei•com>,
"linux-omap@vger•kernel.org" <linux-omap@vger•kernel.org>
Subject: Re: [PATCH net-next 03/14] eth: cpsw: remove a copy of the NAPI_POLL_WEIGHT define
Date: Wed, 27 Apr 2022 08:53:14 -0700 [thread overview]
Message-ID: <20220427085314.326be7d0@kernel.org> (raw)
In-Reply-To: <20220427154702.fbpxfjp4h7ey5ea2@skbuf>
On Wed, 27 Apr 2022 15:47:03 +0000 Vladimir Oltean wrote:
> On Wed, Apr 27, 2022 at 08:41:00AM -0700, Jakub Kicinski wrote:
> > Defining local versions of NAPI_POLL_WEIGHT with the same
> > values in the drivers just makes refactoring harder.
> >
> > Signed-off-by: Jakub Kicinski <kuba@kernel•org>
> > ---
> > CC: grygorii.strashko@ti•com
> > CC: chi.minghao@zte•com.cn
> > CC: vladimir.oltean@nxp•com
>
> Fine with me (I mean, I don't even know why I'm copied on cpsw changes).
get_maintainer, I didn't bother filtering this time
> Why is the weight even an argument to netif_napi_add() anyway?
Right, not sure, see the cover letter.
next prev parent reply other threads:[~2022-04-27 15:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 15:40 [PATCH net-next 00/14] remove copies of the NAPI_POLL_WEIGHT define Jakub Kicinski
2022-04-27 15:40 ` [PATCH net-next 01/14] eth: " Jakub Kicinski
2022-05-01 22:10 ` Linus Walleij
2022-04-27 15:40 ` [PATCH net-next 02/14] eth: remove NAPI_WEIGHT defines Jakub Kicinski
2022-04-27 17:41 ` Greg KH
2022-04-27 15:41 ` [PATCH net-next 03/14] eth: cpsw: remove a copy of the NAPI_POLL_WEIGHT define Jakub Kicinski
2022-04-27 15:47 ` Vladimir Oltean
2022-04-27 15:53 ` Jakub Kicinski [this message]
2022-04-27 21:06 ` Francois Romieu
2022-04-27 15:41 ` [PATCH net-next 04/14] eth: pch_gbe: " Jakub Kicinski
2022-04-28 9:57 ` Andy Shevchenko
2022-04-27 15:41 ` [PATCH net-next 05/14] eth: mtk_eth_soc: " Jakub Kicinski
2022-04-27 15:41 ` [PATCH net-next 06/14] usb: lan78xx: " Jakub Kicinski
2022-04-27 15:41 ` [PATCH net-next 07/14] slic: " Jakub Kicinski
2022-04-27 15:41 ` [PATCH net-next 08/14] eth: bgnet: " Jakub Kicinski
2022-04-27 16:09 ` Florian Fainelli
2022-04-27 16:53 ` Jakub Kicinski
2022-04-27 17:32 ` Florian Fainelli
2022-04-27 15:41 ` [PATCH net-next 09/14] eth: atlantic: " Jakub Kicinski
2022-04-27 15:41 ` [PATCH net-next 10/14] eth: benet: " Jakub Kicinski
2022-04-27 15:41 ` [PATCH net-next 11/14] eth: gfar: " Jakub Kicinski
2022-04-27 15:41 ` [PATCH net-next 12/14] eth: vxge: " Jakub Kicinski
2022-04-27 15:41 ` [PATCH net-next 13/14] eth: spider: " Jakub Kicinski
2022-04-27 21:56 ` Geoff Levand
2022-04-27 15:41 ` [PATCH net-next 14/14] eth: velocity: " Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220427085314.326be7d0@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=chenhao288@hisilicon$(echo .)com \
--cc=chi.minghao@zte$(echo .)com.cn \
--cc=davem@davemloft$(echo .)net \
--cc=grygorii.strashko@ti$(echo .)com \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=moyufeng@huawei$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=toke@redhat$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox