From: Jakub Kicinski <kuba@kernel•org>
To: Cong Wang <xiyou.wangcong@gmail•com>
Cc: Linux Kernel Network Developers <netdev@vger•kernel.org>,
Cong Wang <cong.wang@bytedance•com>,
Eric Dumazet <edumazet@google•com>,
John Fastabend <john.fastabend@gmail•com>,
Daniel Borkmann <daniel@iogearbox•net>,
Jakub Sitnicki <jakub@cloudflare•com>
Subject: Re: [Patch bpf-next v1 1/4] tcp: introduce tcp_read_skb()
Date: Mon, 2 May 2022 09:13:11 -0700 [thread overview]
Message-ID: <20220502091311.2cbc2c32@kernel.org> (raw)
In-Reply-To: <CAM_iQpX0Ej+dCCum8mpVM+dYmi=dxmDa+OhnVEQhoB9av_yGDQ@mail.gmail.com>
On Sat, 30 Apr 2022 10:22:33 -0700 Cong Wang wrote:
> > I started prototyping a similar patch for TLS a while back but I have
> > two functions - one to get the skb and another to consume it. I thought
> > that's better for TLS, otherwise skbs stuck in the middle layer are not
> > counted towards the rbuf. Any thoughts on structuring the API that way?
> > I guess we can refactor that later, since TLS TCP-only we don't need
> > proto_ops plumbing there.
>
> Do you have a pointer to the source code? I am not sure how TLS uses
> ->read_sock() (or which interface is relevant).
Nothing useful, I started hacking on removing strparser but then got
distracted with functional optimizations. TLS calls ->read_sock() thru
strparser.
With a little bit of code duplication TLS should be able to avoid
the strparser's heavy machinery and cloning each skb.
next prev parent reply other threads:[~2022-05-02 16:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-10 16:10 [Patch bpf-next v1 0/4] sockmap: some performance optimizations Cong Wang
2022-04-10 16:10 ` [Patch bpf-next v1 1/4] tcp: introduce tcp_read_skb() Cong Wang
2022-04-12 20:00 ` John Fastabend
2022-04-21 19:00 ` Cong Wang
2022-04-26 6:27 ` John Fastabend
2022-04-30 17:17 ` Cong Wang
2022-04-25 19:07 ` Jakub Kicinski
2022-04-30 17:22 ` Cong Wang
2022-05-02 16:13 ` Jakub Kicinski [this message]
2022-04-26 9:11 ` Jakub Sitnicki
2022-04-30 17:18 ` Cong Wang
2022-04-10 16:10 ` [Patch bpf-next v1 2/4] net: introduce a new proto_ops ->read_skb() Cong Wang
2022-04-10 16:10 ` [Patch bpf-next v1 3/4] skmsg: get rid of skb_clone() Cong Wang
2022-04-10 16:10 ` [Patch bpf-next v1 4/4] skmsg: get rid of unncessary memset() Cong Wang
2022-04-26 9:27 ` [Patch bpf-next v1 0/4] sockmap: some performance optimizations Jakub Sitnicki
2022-04-30 17:27 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220502091311.2cbc2c32@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=cong.wang@bytedance$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jakub@cloudflare$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox