Subject: Re: [PATCH 2/2] net: phy: adin: add adi,clk_rcvr_125_en property

From: Jakub Kicinski <[email-masked]>
Date: Mon, 2 May 2022 15:03:05 -0700

On Fri, 29 Apr 2022 13:44:32 -0500 Nate Drude wrote:
> +	if (of_property_read_bool(of_node, "adi,clk_rcvr_125_en")) {
> +		reg = phy_read_mmd(phydev, MDIO_MMD_VEND1, ADIN1300_GE_CLK_CFG);
> +
> +		reg |= ADIN1300_GE_CLK_RCVR_125_EN;
> +
> +		phydev_dbg(phydev, "%s: ADIN1300_GE_CLK_CFG = %x\n",
> +		           __func__, reg);
> +
> +		reg = phy_write_mmd(phydev, MDIO_MMD_VEND1,
> +			     ADIN1300_GE_CLK_CFG, reg);

Looks like you could use phy_modify_mmd() instead.

The print could be removed IMHO, it adds little value. All it does is
says the register write was performed, not even old an new values.

Please CC the folks and list pointed out by Paolo and Josua from the
thread pointed out by Andrew.

Please tag v2 as [PATCH net-next v2] in the subject.

Thanks!