From: Jakub Kicinski <kuba@kernel•org>
To: Jonathan Lemon <jonathan.lemon@gmail•com>
Cc: andrew@lunn•ch, hkallweit1@gmail•com, linux@armlinux•org.uk,
f.fainelli@gmail•com, bcm-kernel-feedback-list@broadcom•com,
netdev@vger•kernel.org, kernel-team@fb•com, davem@davemloft•net,
pabeni@redhat•com, edumazet@google•com, lasse@timebeat•app,
clk@fb•com
Subject: Re: [PATCH net-next v4 1/2] net: phy: broadcom: Add PTP support for some Broadcom PHYs.
Date: Fri, 6 May 2022 20:57:49 -0700 [thread overview]
Message-ID: <20220506205749.2b89ee57@kernel.org> (raw)
In-Reply-To: <20220506224210.1425817-2-jonathan.lemon@gmail.com>
On Fri, 6 May 2022 15:42:09 -0700 Jonathan Lemon wrote:
> +struct bcm_ptp_private *bcm_ptp_probe(struct phy_device *phydev)
The prototype for probe and init needs to get added in patch 1:
drivers/net/phy/bcm-phy-ptp.c:803:6: warning: no previous prototype for function 'bcm_ptp_config_init' [-Wmissing-prototypes]
void bcm_ptp_config_init(struct phy_device *phydev)
^
drivers/net/phy/bcm-phy-ptp.c:839:25: warning: no previous prototype for function 'bcm_ptp_probe' [-Wmissing-prototypes]
struct bcm_ptp_private *bcm_ptp_probe(struct phy_device *phydev)
^
next prev parent reply other threads:[~2022-05-07 3:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 22:42 [PATCH net-next v4 0/2] Broadcom PTP PHY support Jonathan Lemon
2022-05-06 22:42 ` [PATCH net-next v4 1/2] net: phy: broadcom: Add PTP support for some Broadcom PHYs Jonathan Lemon
2022-05-07 3:57 ` Jakub Kicinski [this message]
2022-05-06 22:42 ` [PATCH net-next v4 2/2] net: phy: broadcom: Add Broadcom PTP hooks to bcm-phy-lib Jonathan Lemon
2022-05-18 20:14 ` [PATCH net-next v4 0/2] Broadcom PTP PHY support Florian Fainelli
2022-05-18 20:50 ` Jonathan Lemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220506205749.2b89ee57@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=clk@fb$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=jonathan.lemon@gmail$(echo .)com \
--cc=kernel-team@fb$(echo .)com \
--cc=lasse@timebeat$(echo .)app \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox