Subject: Re: [PATCH v5 net-next 13/13] mlx5: support BIG TCP packets

From: Jakub Kicinski <[email-masked]>
Date: Mon, 9 May 2022 18:38:53 -0700

On Mon,  9 May 2022 15:21:49 -0700 Eric Dumazet wrote:
> From: Coco Li <[email-masked]>
> 
> mlx5 supports LSOv2.
> 
> IPv6 gro/tcp stacks insert a temporary Hop-by-Hop header
> with JUMBO TLV for big packets.
> 
> We need to ignore/skip this HBH header when populating TX descriptor.
> 
> Note that ipv6_has_hopopt_jumbo() only recognizes very specific packet
> layout, thus mlx5e_sq_xmit_wqe() is taking care of this layout only.
> 
> v2: clear hopbyhop in mlx5e_tx_get_gso_ihs()
> v4: fix compile error for CONFIG_MLX5_CORE_IPOIB=y
> 
> Signed-off-by: Coco Li <[email-masked]>
> Signed-off-by: Eric Dumazet <[email-masked]>
> Reviewed-by: Tariq Toukan <[email-masked]>
> Cc: Saeed Mahameed <[email-masked]>
> Cc: Leon Romanovsky <[email-masked]>

So we're leaving the warning for Kees to deal with?

Kees is there some form of "I know what I'm doing" cast 
that you could sneak us under the table?