Subject: Re: [PATCH net-next 3/6] eth: switch to netif_napi_add_weight()

From: Jakub Kicinski <[email-masked]>
Date: Wed, 11 May 2022 12:45:51 -0700

On Wed, 11 May 2022 18:57:53 +0100 Edward Cree wrote:
> > diff --git a/drivers/net/ethernet/sfc/efx_channels.c b/drivers/net/ethernet/sfc/efx_channels.c
> > index eec80b024195..3f28f9861dfa 100644
> > --- a/drivers/net/ethernet/sfc/efx_channels.c
> > +++ b/drivers/net/ethernet/sfc/efx_channels.c
> > @@ -1316,8 +1316,8 @@ void efx_init_napi_channel(struct efx_channel *channel)
> >  	struct efx_nic *efx = channel->efx;
> >  
> >  	channel->napi_dev = efx->net_dev;
> > -	netif_napi_add(channel->napi_dev, &channel->napi_str,
> > -		       efx_poll, napi_weight);
> > +	netif_napi_add_weight(channel->napi_dev, &channel->napi_str, efx_poll,
> > +			      napi_weight);
> >  }  
> 
> This isn't really a custom weight; napi_weight is initialised to
>  64 and never changed, so probably we ought to be just using
>  NAPI_POLL_WEIGHT here and end up on the non-_weight API.
> Same goes for Falcon.

Ack, I wanted to be nice. I figured this must be a stub for a module
param in your our of tree driver. Should I send a patch to remove
the non-const static napi_weight globals and switch back to non-_weight?