From: Jakub Kicinski <kuba@kernel•org>
To: Menglong Dong <menglong8.dong@gmail•com>
Cc: Neil Horman <nhorman@tuxdriver•com>,
David Miller <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6•org>,
David Ahern <dsahern@kernel•org>,
Menglong Dong <imagedong@tencent•com>, Martin Lau <kafai@fb•com>,
Talal Ahmad <talalahmad@google•com>,
Kees Cook <keescook@chromium•org>,
asml.silence@gmail•com, Willem de Bruijn <willemb@google•com>,
vasily.averin@linux•dev,
Ilias Apalodimas <ilias.apalodimas@linaro•org>,
Luiz Augusto von Dentz <luiz.von.dentz@intel•com>,
LKML <linux-kernel@vger•kernel.org>,
netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next 0/4] net: skb: check the boundrary of skb drop reason
Date: Thu, 12 May 2022 09:13:23 -0700 [thread overview]
Message-ID: <20220512091323.63ea232c@kernel.org> (raw)
In-Reply-To: <CADxym3Zqe=9TA_JBYCEX2tqeVxLN_LbH_F_zQuoXBG4XK=mc7g@mail.gmail.com>
On Thu, 12 May 2022 20:31:14 +0800 Menglong Dong wrote:
> On Thu, May 12, 2022 at 2:26 PM <menglong8.dong@gmail•com> wrote:
> >
> > From: Menglong Dong <imagedong@tencent•com>
> >
> > In the commit 1330b6ef3313 ("skb: make drop reason booleanable"),
> > SKB_NOT_DROPPED_YET is added to the enum skb_drop_reason, which makes
> > the invalid drop reason SKB_NOT_DROPPED_YET can leak to the kfree_skb
> > tracepoint. Once this happen (it happened, as 4th patch says), it can
> > cause NULL pointer in drop monitor and result in kernel panic.
> >
> > Therefore, check the boundrary of drop reason in both kfree_skb_reason
> > (2th patch) and drop monitor (1th patch).
> >
> > Meanwhile, fix the invalid drop reason passed to kfree_skb_reason() in
> > tcp_v4_rcv().
> >
>
> tcp_v6_rcv() is forgeted, I'll send a V2 :/
Please don't repost stuff within 24h:
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#i-have-received-review-feedback-when-should-i-post-a-revised-version-of-the-patches
I could have given you the same exact feedback on v1 as v2...
prev parent reply other threads:[~2022-05-12 16:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 6:26 [PATCH net-next 0/4] net: skb: check the boundrary of skb drop reason menglong8.dong
2022-05-12 6:26 ` [PATCH net-next 1/4] net: dm: check the boundary of skb drop reasons menglong8.dong
2022-05-12 6:26 ` [PATCH net-next 2/4] net: skb: check the boundrary of drop reason in kfree_skb_reason() menglong8.dong
2022-05-12 6:26 ` [PATCH net-next 3/4] net: skb: change the definition SKB_DR_SET() menglong8.dong
2022-05-12 6:26 ` [PATCH net-next 4/4] net: tcp: reset skb drop reason to NOT_SPCIFIED in tcp_v4_rcv() menglong8.dong
2022-05-12 12:31 ` [PATCH net-next 0/4] net: skb: check the boundrary of skb drop reason Menglong Dong
2022-05-12 16:13 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512091323.63ea232c@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=asml.silence@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=ilias.apalodimas@linaro$(echo .)org \
--cc=imagedong@tencent$(echo .)com \
--cc=kafai@fb$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=luiz.von.dentz@intel$(echo .)com \
--cc=menglong8.dong@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=talalahmad@google$(echo .)com \
--cc=vasily.averin@linux$(echo .)dev \
--cc=willemb@google$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox