Subject: Re: [PATCH net-next v3 2/7] usbnet: smsc95xx: Don't clear read-only PHY interrupt

From: Lukas Wunner <[email-masked]>
Date: Thu, 12 May 2022 13:57:30 +0200

On Thu, May 12, 2022 at 10:42:02AM +0200, Lukas Wunner wrote:
> Upon receiving data from the Interrupt Endpoint, the SMSC LAN95xx driver
> attempts to clear the signaled interrupts by writing "all ones" to the
> Interrupt Status Register.
> 
> However the driver only ever enables a single type of interrupt, namely
> the PHY Interrupt.  And according to page 119 of the LAN950x datasheet,
> its bit in the Interrupt Status Register is read-only.  There's no other
> way to clear it than in a separate PHY register:
> 
> https://www.microchip.com/content/dam/mchp/documents/UNG/ProductDocuments/DataSheets/LAN950x-Data-Sheet-DS00001875D.pdf
> 
> Consequently, writing "all ones" to the Interrupt Status Register is
> pointless and can be dropped.
> 
> Tested-by: Oleksij Rempel <[email-masked]> # LAN9514/9512/9500
> Tested-by: Ferry Toth <[email-masked]> # LAN9514
> Signed-off-by: Lukas Wunner <[email-masked]>

Reviewed-by: Andrew Lunn <[email-masked]>

Forgot to add Andrew's R-b which he kindly provided here:
https://lore.kernel.org/netdev/[email-masked]/

Let's see if patchwork picks the tag up if I add it like this.
My apologies for the inconvenience.