From: Rob Herring <robh@kernel•org>
To: "Rafał Miłecki" <zajec5@gmail•com>
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro•org>,
"Pavel Machek" <pavel@ucw•cz>,
"David S . Miller" <davem@davemloft•net>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
"Florian Fainelli" <f.fainelli@gmail•com>,
"Hauke Mehrtens" <hauke@hauke-m•de>,
"Jacek Anaszewski" <jacek.anaszewski@gmail•com>,
devicetree@vger•kernel.org, netdev@vger•kernel.org,
linux-leds@vger•kernel.org, linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org,
bcm-kernel-feedback-list@broadcom•com, ansuelsmth@gmail•com,
andrew@lunn•ch, vivien.didelot@gmail•com,
"Vladimir Oltean" <olteanv@gmail•com>,
"Jonathan Corbet" <corbet@lwn•net>,
"John Crispin" <john@phrozen•org>,
linux-doc@vger•kernel.org, "Rafał Miłecki" <rafal@milecki•pl>
Subject: Re: [PATCH RESEND 1/5] dt-bindings: net: add bitfield defines for Ethernet speeds
Date: Tue, 17 May 2022 15:35:08 -0500 [thread overview]
Message-ID: <20220517203508.GA1587170-robh@kernel.org> (raw)
In-Reply-To: <20220505135512.3486-2-zajec5@gmail.com>
On Thu, May 05, 2022 at 03:55:08PM +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki•pl>
>
> This allows specifying multiple Ethernet speeds in a single DT uint32
> value.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki•pl>
> ---
> include/dt-bindings/net/eth.h | 27 +++++++++++++++++++++++++++
ethernet.h
> 1 file changed, 27 insertions(+)
> create mode 100644 include/dt-bindings/net/eth.h
>
> diff --git a/include/dt-bindings/net/eth.h b/include/dt-bindings/net/eth.h
> new file mode 100644
> index 000000000000..89caff09179b
> --- /dev/null
> +++ b/include/dt-bindings/net/eth.h
> @@ -0,0 +1,27 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
Dual license
> +/*
> + * Device Tree constants for the Ethernet
> + */
> +
> +#ifndef _DT_BINDINGS_ETH_H
> +#define _DT_BINDINGS_ETH_H
> +
> +#define SPEED_UNSPEC 0
> +#define SPEED_10 (1 << 0)
> +#define SPEED_100 (1 << 1)
> +#define SPEED_1000 (1 << 2)
> +#define SPEED_2000 (1 << 3)
> +#define SPEED_2500 (1 << 4)
> +#define SPEED_5000 (1 << 5)
> +#define SPEED_10000 (1 << 6)
> +#define SPEED_14000 (1 << 7)
> +#define SPEED_20000 (1 << 8)
> +#define SPEED_25000 (1 << 9)
> +#define SPEED_40000 (1 << 10)
> +#define SPEED_50000 (1 << 11)
> +#define SPEED_56000 (1 << 12)
> +#define SPEED_100000 (1 << 13)
> +#define SPEED_200000 (1 << 14)
> +#define SPEED_400000 (1 << 15)
These should probably have some namespace. ETH_*?
> +
> +#endif
> --
> 2.34.1
>
>
next prev parent reply other threads:[~2022-05-17 20:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 13:55 [PATCH RESEND 0/5] dt-bindings: support Ethernet devices as LED triggers Rafał Miłecki
2022-05-05 13:55 ` [PATCH RESEND 1/5] dt-bindings: net: add bitfield defines for Ethernet speeds Rafał Miłecki
2022-05-17 20:35 ` Rob Herring [this message]
2022-05-05 13:55 ` [PATCH RESEND 2/5] dt-bindings: net: allow Ethernet devices as LED triggers Rafał Miłecki
2022-05-17 20:37 ` Rob Herring
2022-05-05 13:55 ` [PATCH RESEND 3/5] dt-bindings: leds: add Ethernet triggered LEDs to example Rafał Miłecki
2022-05-05 13:55 ` [PATCH RESEND 4/5] ARM: dts: BCM5301X: Add triggers for Luxul XWR-1200 network LEDs Rafał Miłecki
2022-05-05 13:55 ` [PATCH RESEND PoC] leds: trigger: netdev: support DT "trigger-sources" property Rafał Miłecki
2022-05-05 14:02 ` [PATCH RESEND 0/5] dt-bindings: support Ethernet devices as LED triggers Ansuel Smith
2022-05-05 14:21 ` Rafał Miłecki
2022-05-05 14:30 ` Ansuel Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517203508.GA1587170-robh@kernel.org \
--to=robh@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=ansuelsmth@gmail$(echo .)com \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hauke@hauke-m$(echo .)de \
--cc=jacek.anaszewski@gmail$(echo .)com \
--cc=john@phrozen$(echo .)org \
--cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-leds@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=pavel@ucw$(echo .)cz \
--cc=rafal@milecki$(echo .)pl \
--cc=vivien.didelot@gmail$(echo .)com \
--cc=zajec5@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox