From: Jakub Kicinski <kuba@kernel•org>
To: menglong8.dong@gmail•com
Cc: nhorman@tuxdriver•com, davem@davemloft•net, edumazet@google•com,
pabeni@redhat•com, yoshfuji@linux-ipv6•org, dsahern@kernel•org,
imagedong@tencent•com, kafai@fb•com, talalahmad@google•com,
keescook@chromium•org, asml.silence@gmail•com,
willemb@google•com, vasily.averin@linux•dev,
ilias.apalodimas@linaro•org, luiz.von.dentz@intel•com,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
Jiang Biao <benbjiang@tencent•com>,
Hao Peng <flyingpeng@tencent•com>
Subject: Re: [PATCH net-next v3 4/4] net: tcp: reset 'drop_reason' to NOT_SPCIFIED in tcp_v{4,6}_rcv()
Date: Thu, 19 May 2022 08:48:51 -0700 [thread overview]
Message-ID: <20220519084851.4bce4bdd@kernel.org> (raw)
In-Reply-To: <20220513030339.336580-5-imagedong@tencent.com>
On Fri, 13 May 2022 11:03:39 +0800 menglong8.dong@gmail•com wrote:
> From: Menglong Dong <imagedong@tencent•com>
>
> The 'drop_reason' that passed to kfree_skb_reason() in tcp_v4_rcv()
> and tcp_v6_rcv() can be SKB_NOT_DROPPED_YET(0), as it is used as the
> return value of tcp_inbound_md5_hash().
>
> And it can panic the kernel with NULL pointer in
> net_dm_packet_report_size() if the reason is 0, as drop_reasons[0]
> is NULL.
>
> Fixes: 1330b6ef3313 ("skb: make drop reason booleanable")
This patch is in net, should this fix have been targeting net / 5.18?
next prev parent reply other threads:[~2022-05-19 15:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 3:03 [PATCH net-next v3 0/4] net: skb: check the boundrary of skb drop reason menglong8.dong
2022-05-13 3:03 ` [PATCH net-next v3 1/4] net: dm: check the boundary of skb drop reasons menglong8.dong
2022-05-13 3:03 ` [PATCH net-next v3 2/4] net: skb: check the boundrary of drop reason in kfree_skb_reason() menglong8.dong
2022-05-13 3:03 ` [PATCH net-next v3 3/4] net: skb: change the definition SKB_DR_SET() menglong8.dong
2022-05-13 3:03 ` [PATCH net-next v3 4/4] net: tcp: reset 'drop_reason' to NOT_SPCIFIED in tcp_v{4,6}_rcv() menglong8.dong
2022-05-19 15:48 ` Jakub Kicinski [this message]
2022-05-20 1:46 ` Menglong Dong
2022-05-20 2:09 ` Jakub Kicinski
2022-05-20 2:18 ` Jakub Kicinski
2022-05-20 2:39 ` Menglong Dong
2022-05-16 10:00 ` [PATCH net-next v3 0/4] net: skb: check the boundrary of skb drop reason patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220519084851.4bce4bdd@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=asml.silence@gmail$(echo .)com \
--cc=benbjiang@tencent$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=flyingpeng@tencent$(echo .)com \
--cc=ilias.apalodimas@linaro$(echo .)org \
--cc=imagedong@tencent$(echo .)com \
--cc=kafai@fb$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=luiz.von.dentz@intel$(echo .)com \
--cc=menglong8.dong@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=talalahmad@google$(echo .)com \
--cc=vasily.averin@linux$(echo .)dev \
--cc=willemb@google$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox