Subject: Re: regression: 'ctnetlink_dump_one_entry' defined but not used

From: Jakub Kicinski <[email-masked]>
Date: Thu, 19 May 2022 13:13:41 -0700

On Thu, 19 May 2022 12:21:00 +0200 Florian Westphal wrote:
> Oliver Smith <[email-masked]> wrote:
> > Hi Florian,
> > 
> > since May 17 we see some automatic builds against net-next.git fail with:
> >   
> > > net/netfilter/nf_conntrack_netlink.c:1717:12: error: 'ctnetlink_dump_one_entry' defined but not used [-Werror=unused-function]
> > >  1717 | static int ctnetlink_dump_one_entry(struct sk_buff *skb,
> > >       |            ^~~~~~~~~~~~~~~~~~~~~~~~  
> > 
> > Looks like this is a regression from your patch 8a75a2c17, I guess
> > ctnetlink_dump_one_entry needs #ifdef CONFIG_NF_CONNTRACK_EVENTS?  
> 
> Its fixed in nf-next.

Let's get it out to net-next, please, I'm carrying this patch locally
as well :(