Subject: Re: [PATCH net] nfp: correct the output of `ethtool --show-fec <intf>`

From: Jakub Kicinski <[email-masked]>
Date: Mon, 30 May 2022 21:32:32 -0700

On Mon, 30 May 2022 10:48:42 +0200 Simon Horman wrote:
> The output  of `Configured FEC encodings` should display user
> configured/requested value,

That stands to reason, but when I checked what all drivers do 7 out 
of 10 upstream drivers at the time used it to report supported modes.
At which point it may be better to change the text in ethtool user
space that try to change the meaning of the field..

> rather than the NIC supported modes list.
> 
> Before this patch, the output is:
>  # ethtool --show-fec <intf>
>  FEC parameters for <intf>:
>  Configured FEC encodings: Auto Off RS BaseR
>  Active FEC encoding: None
> 
> With this patch, the corrected output is:
>  # ethtool --show-fec <intf>
>  FEC parameters for <intf>:
>  Configured FEC encodings: Auto
>  Active FEC encoding: None