Subject: Re: [PATCH] net: eth: altera: set rx and tx ring size before init_dma call

From: Jakub Kicinski <[email-masked]>
Date: Tue, 31 May 2022 20:50:11 -0700

On Tue, 31 May 2022 10:51:17 +0800 Tham, Mun Yew wrote:
> It is more appropriate to set the rx and tx ring size before calling
> the init function for the dma.

Improve the commit message please, this tells us nothing.
It's hardly a well know software design best practice to set some
random thing before calling another random thing.
AFAICT neither dma implementation upstream cares about
priv->[tr]x_ring_size, do they?

If you're doing this to prepare for adding another DMA engine,
please post this patch together with the support being added.