From: Richard Gobert <richardbgobert@gmail•com>
To: Jakub Kicinski <kuba@kernel•org>
Cc: davem@davemloft•net, pabeni@redhat•com,
steffen.klassert@secunet•com, herbert@gondor•apana.org.au,
yoshfuji@linux-ipv6•org, dsahern@kernel•org, edumazet@google•com,
willemb@google•com, imagedong@tencent•com, talalahmad@google•com,
kafai@fb•com, vasily.averin@linux•dev, luiz.von.dentz@intel•com,
jk@codeconstruct•com.au, netdev@vger•kernel.org
Subject: Re: [PATCH v2] net: helper function for skb_shift
Date: Wed, 22 Jun 2022 12:25:20 +0200 [thread overview]
Message-ID: <20220622102517.GA4171@debian> (raw)
In-Reply-To: <20220621221240.36c6a3a6@kernel.org>
On Tue, Jun 21, 2022 at 10:12:40PM -0700, Jakub Kicinski wrote:
> That's better, thanks. Please move the helper to skbuff.h
Will do.
> and consider changing the subject from talking about skb_shift()
> which is just one of the users now to mentioning the helper's name.
When submitting the updated patch with a new subject, should it be marked v3
or is it considered a new patch entirely?
next prev parent reply other threads:[~2022-06-22 10:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 15:56 [PATCH v2] net: helper function for skb_shift Richard Gobert
2022-06-22 5:12 ` Jakub Kicinski
2022-06-22 10:25 ` Richard Gobert [this message]
2022-06-22 15:37 ` Jakub Kicinski
2022-06-22 5:14 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220622102517.GA4171@debian \
--to=richardbgobert@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=imagedong@tencent$(echo .)com \
--cc=jk@codeconstruct$(echo .)com.au \
--cc=kafai@fb$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=luiz.von.dentz@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=steffen.klassert@secunet$(echo .)com \
--cc=talalahmad@google$(echo .)com \
--cc=vasily.averin@linux$(echo .)dev \
--cc=willemb@google$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox