From: Jakub Kicinski <kuba@kernel•org>
To: Andrew Lunn <andrew@lunn•ch>
Cc: Praghadeesh T K S <praghadeeshthevendria@gmail•com>,
Rain River <rain.1986.08.12@gmail•com>,
Zhu Yanjun <zyjzyj2000@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
skhan@linuxfoundation•org, praghadeeshtks@zohomail•in,
linux-kernel-mentees@lists•linuxfoundation.org
Subject: Re: [PATCH] net: ethernet/nvidia: fix possible condition with no effect
Date: Mon, 27 Jun 2022 11:38:12 -0700 [thread overview]
Message-ID: <20220627113812.08ae31f0@kernel.org> (raw)
In-Reply-To: <Yrg+NZHBNcu3KFXn@lunn.ch>
On Sun, 26 Jun 2022 13:08:37 +0200 Andrew Lunn wrote:
> On Sun, Jun 26, 2022 at 10:35:39AM +0000, Praghadeesh T K S wrote:
> > Fix Coccinelle bug, removed condition with no effect.
>
> This is not a coccinelle bug. If it was, you would be patching
> coccinelle, not the kernel.
I'd say the commit message is better than the commit ;)
Praghadeesh, could you fix Coccinelle to avoid matching:
if (/* case 1 */) {
/* BLOCK 1*/
} else (/* case 2 */ {
/* BLOCK 2 */
} else {
/* default == BLOCK 2 */
}
Because 99% of the time that construct is intentional.
prev parent reply other threads:[~2022-06-27 18:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-26 10:35 [PATCH] net: ethernet/nvidia: fix possible condition with no effect Praghadeesh T K S
2022-06-26 11:08 ` Andrew Lunn
2022-06-27 18:38 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220627113812.08ae31f0@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=linux-kernel-mentees@lists$(echo .)linuxfoundation.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=praghadeeshthevendria@gmail$(echo .)com \
--cc=praghadeeshtks@zohomail$(echo .)in \
--cc=rain.1986.08.12@gmail$(echo .)com \
--cc=skhan@linuxfoundation$(echo .)org \
--cc=zyjzyj2000@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox