From: Stephen Hemminger <stephen@networkplumber•org>
To: "Gustavo A. R. Silva" <gustavoars@kernel•org>
Cc: Kees Cook <keescook@chromium•org>,
linux-kernel@vger•kernel.org, x86@kernel•org,
dm-devel@redhat•com, linux-m68k@lists•linux-m68k.org,
linux-mips@vger•kernel.org, linux-s390@vger•kernel.org,
kvm@vger•kernel.org, intel-gfx@lists•freedesktop.org,
dri-devel@lists•freedesktop.org, netdev@vger•kernel.org,
bpf@vger•kernel.org, linux-btrfs@vger•kernel.org,
linux-can@vger•kernel.org, linux-fsdevel@vger•kernel.org,
linux1394-devel@lists•sourceforge.net, io-uring@vger•kernel.org,
lvs-devel@vger•kernel.org, linux-mtd@lists•infradead.org,
kasan-dev@googlegroups•com, linux-mmc@vger•kernel.org,
nvdimm@lists•linux.dev, netfilter-devel@vger•kernel.org,
coreteam@netfilter•org, linux-perf-users@vger•kernel.org,
linux-raid@vger•kernel.org, linux-sctp@vger•kernel.org,
linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org, linux-scsi@vger•kernel.org,
target-devel@vger•kernel.org, linux-usb@vger•kernel.org,
virtualization@lists•linux-foundation.org,
v9fs-developer@lists•sourceforge.net, linux-rdma@vger•kernel.org,
alsa-devel@alsa-project•org, linux-hardening@vger•kernel.org
Subject: Re: [PATCH][next] treewide: uapi: Replace zero-length arrays with flexible-array members
Date: Mon, 27 Jun 2022 12:53:43 -0700 [thread overview]
Message-ID: <20220627125343.44e24c41@hermes.local> (raw)
In-Reply-To: <20220627180432.GA136081@embeddedor>
On Mon, 27 Jun 2022 20:04:32 +0200
"Gustavo A. R. Silva" <gustavoars@kernel•org> wrote:
> There is a regular need in the kernel to provide a way to declare
> having a dynamically sized set of trailing elements in a structure.
> Kernel code should always use “flexible array members”[1] for these
> cases. The older style of one-element or zero-length arrays should
> no longer be used[2].
>
> This code was transformed with the help of Coccinelle:
> (linux-5.19-rc2$ spatch --jobs $(getconf _NPROCESSORS_ONLN) --sp-file script.cocci --include-headers --dir . > output.patch)
>
> @@
> identifier S, member, array;
> type T1, T2;
> @@
>
> struct S {
> ...
> T1 member;
> T2 array[
> - 0
> ];
> };
>
> -fstrict-flex-arrays=3 is coming and we need to land these changes
> to prevent issues like these in the short future:
>
> ../fs/minix/dir.c:337:3: warning: 'strcpy' will always overflow; destination buffer has size 0,
> but the source string has length 2 (including NUL byte) [-Wfortify-source]
> strcpy(de3->name, ".");
> ^
>
> Since these are all [0] to [] changes, the risk to UAPI is nearly zero. If
> this breaks anything, we can use a union with a new member name.
>
> [1] https://en.wikipedia.org/wiki/Flexible_array_member
> [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
>
> Link: https://github.com/KSPP/linux/issues/78
> Build-tested-by: https://lore.kernel.org/lkml/62b675ec.wKX6AOZ6cbE71vtF%25lkp@intel.com/
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel•org>
Thanks this fixes warning with gcc-12 in iproute2.
In function ‘xfrm_algo_parse’,
inlined from ‘xfrm_state_modify.constprop’ at xfrm_state.c:573:5:
xfrm_state.c:162:32: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
162 | buf[j] = val;
| ~~~~~~~^~~~~
next prev parent reply other threads:[~2022-06-27 19:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 18:04 [PATCH][next] treewide: uapi: Replace zero-length arrays with flexible-array members Gustavo A. R. Silva
2022-06-27 18:27 ` Daniel Borkmann
2022-06-27 18:35 ` Gustavo A. R. Silva
2022-06-28 0:40 ` Jason Gunthorpe
2022-06-28 0:58 ` Gustavo A. R. Silva
2022-06-28 2:21 ` Gustavo A. R. Silva
2022-06-28 13:36 ` Jason Gunthorpe
2022-06-28 13:56 ` Gustavo A. R. Silva
2022-06-28 17:54 ` Kees Cook
2022-06-28 18:44 ` Jason Gunthorpe
2022-06-27 19:53 ` Stephen Hemminger [this message]
2022-06-28 14:18 ` Gustavo A. R. Silva
2022-06-27 22:31 ` Dan Williams
2022-06-28 7:27 ` Geert Uytterhoeven
2022-06-28 18:05 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220627125343.44e24c41@hermes.local \
--to=stephen@networkplumber$(echo .)org \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=coreteam@netfilter$(echo .)org \
--cc=dm-devel@redhat$(echo .)com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=gustavoars@kernel$(echo .)org \
--cc=intel-gfx@lists$(echo .)freedesktop.org \
--cc=io-uring@vger$(echo .)kernel.org \
--cc=kasan-dev@googlegroups$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-btrfs@vger$(echo .)kernel.org \
--cc=linux-can@vger$(echo .)kernel.org \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-hardening@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-m68k@lists$(echo .)linux-m68k.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-mmc@vger$(echo .)kernel.org \
--cc=linux-mtd@lists$(echo .)infradead.org \
--cc=linux-perf-users@vger$(echo .)kernel.org \
--cc=linux-raid@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=linux-sctp@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linux1394-devel@lists$(echo .)sourceforge.net \
--cc=lvs-devel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=nvdimm@lists$(echo .)linux.dev \
--cc=target-devel@vger$(echo .)kernel.org \
--cc=v9fs-developer@lists$(echo .)sourceforge.net \
--cc=virtualization@lists$(echo .)linux-foundation.org \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox