Subject: Re: [PATCH v3 net] af_unix: Do not call kmemdup() for init_net's sysctl table.

From: Kuniyuki Iwashima <[email-masked]>
Date: Tue, 28 Jun 2022 20:55:46 -0700

From:   Jakub Kicinski <[email-masked]>
Date:   Tue, 28 Jun 2022 20:51:25 -0700
> On Mon, 27 Jun 2022 16:36:27 -0700 Kuniyuki Iwashima wrote:
> > While setting up init_net's sysctl table, we need not duplicate the
> > global table and can use it directly as ipv4_sysctl_init_net() does.
> > 
> > Unlike IPv4, AF_UNIX does not have a huge sysctl table for now, so it
> > cannot be a problem, but this patch makes code consistent.
> 
> Thanks for the extra info. It sounds like an optimization, tho.
> We save one table's worth of memory. Any objections to applying
> this to net-next?

I'm fine with net-next.

Thank you,
Kuniyuki

> > Fixes: 1597fbc0faf8 ("[UNIX]: Make the unix sysctl tables per-namespace")
> > Acked-by: Eric W. Biederman <[email-masked]>
> > Signed-off-by: Kuniyuki Iwashima <[email-masked]>