From: Jakub Kicinski <kuba@kernel•org>
To: davem@davemloft•net
Cc: netdev@vger•kernel.org, edumazet@google•com, pabeni@redhat•com,
andrew@lunn•ch, Jakub Kicinski <kuba@kernel•org>
Subject: [PATCH net v2 1/3] docs: netdev: document that patch series length limit
Date: Fri, 1 Jul 2022 20:12:07 -0700 [thread overview]
Message-ID: <20220702031209.790535-2-kuba@kernel.org> (raw)
In-Reply-To: <20220702031209.790535-1-kuba@kernel.org>
We had been asking people to avoid massive patch series but it does
not appear in the FAQ.
Signed-off-by: Jakub Kicinski <kuba@kernel•org>
---
Documentation/process/maintainer-netdev.rst | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/Documentation/process/maintainer-netdev.rst b/Documentation/process/maintainer-netdev.rst
index c456b5225d66..79a10d05031e 100644
--- a/Documentation/process/maintainer-netdev.rst
+++ b/Documentation/process/maintainer-netdev.rst
@@ -136,6 +136,20 @@ it to the maintainer to figure out what is the most recent and current
version that should be applied. If there is any doubt, the maintainer
will reply and ask what should be done.
+How do I divide my work into patches?
+-------------------------------------
+
+Put yourself in the shoes of the reviewer. Each patch is read separately
+and therefore should constitute a comprehensible step towards your stated
+goal.
+
+Avoid sending series longer than 15 patches. Larger series takes longer
+to review as reviewers will defer looking at it until they find a large
+chunk of time. A small series can be reviewed in a short time, so Maintainers
+just do it. As a result, a sequence of smaller series gets merged quicker and
+with better review coverage. Re-posting large series also increases the mailing
+list traffic.
+
I made changes to only a few patches in a patch series should I resend only those changed?
------------------------------------------------------------------------------------------
No, please resend the entire patch series and make sure you do number your
--
2.36.1
next prev parent reply other threads:[~2022-07-02 3:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-02 3:12 [PATCH net v2 0/3] docs: netdev: document more of our rules Jakub Kicinski
2022-07-02 3:12 ` Jakub Kicinski [this message]
2022-07-02 20:14 ` [PATCH net v2 1/3] docs: netdev: document that patch series length limit Andrew Lunn
2022-07-02 3:12 ` [PATCH net v2 2/3] docs: netdev: document reverse xmas tree Jakub Kicinski
2022-07-02 20:15 ` Andrew Lunn
2022-07-02 3:12 ` [PATCH net v2 3/3] docs: netdev: add a cheat sheet for the rules Jakub Kicinski
2022-07-02 20:15 ` Andrew Lunn
2022-07-04 9:10 ` [PATCH net v2 0/3] docs: netdev: document more of our rules patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220702031209.790535-2-kuba@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox