Subject: Re: [PATCH net 4/7] iavf: Fix NULL pointer dereference in iavf_get_link_ksettings

From: Jakub Kicinski <[email-masked]>
Date: Tue, 12 Jul 2022 18:26:36 -0700

On Mon, 11 Jul 2022 16:02:40 -0700 Tony Nguyen wrote:
> +	/* if VF failed initialization during __IAVF_INIT_GET_RESOURCES,
> +	 * it is possible for this variable to be freed there.
> +	 */
> +	if (!adapter->vf_res)
> +		return -EAGAIN;

I think I already rejected a similar patch in the past.

ethtool APIs should not return -EAGAIN, if the driver needs to wait 
for some init or reset to finish -- it should just wait, we can't 
throw errors at user space and hope it will retry.